Issue 940603003: Linux Sandbox: always discover Zygote PID properly

Issue 940603003: Linux Sandbox: always discover Zygote PID properly (Closed)

Created:
5 years, 10 months ago by jln (very slow on Chromium)

Modified:
5 years, 10 months ago

Reviewers:
rickyz (no longer on Chrome), mdempsky

CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Linux Sandbox: always discover Zygote PID properly Discover the Zygote's PID properly when using the namespace sandbox. BUG=459724 Committed: https://crrev.com/151ebd71242e36fa18e0bd1d0b5df228a97fbbdf Cr-Commit-Position: refs/heads/master@{#316974}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
M	content/browser/zygote_host/zygote_host_impl_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/zygote/zygote_linux.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/zygote/zygote_linux.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	content/zygote/zygote_main_linux.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

jln (very slow on Chromium)

Given the timeline, I'm tempted to land this trivial fix and we can postpone heavier ...

5 years, 10 months ago (2015-02-18 23:37:07 UTC) #2

mdempsky

lgtm Seems right to me. I think this code should all be fine with the ...

5 years, 10 months ago (2015-02-19 01:08:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940603003/20001

5 years, 10 months ago (2015-02-19 01:33:07 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 02:22:32 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/151ebd71242e36fa18e0bd1d0b5df228a97fbbdf
Cr-Commit-Position: refs/heads/master@{#316974}