A few tests fails when I run them with --hydrogen-track-positions

A few tests fails when I run them with --hydrogen-track-positions

The root of problem is the fact that we don't track the position of 'this' statement but use them when visit compare statement.
As a result we have -1 as the position of left expression and the resulting relative position is negative and doesn't fit into BitField.

BUG=452067
TEST=test-cpu-profiler/SourceLocation
LOG=n

Committed: https://crrev.com/36ed9ca348a6d89a35e966db1b8ae77b2ac176a0
Cr-Commit-Position: refs/heads/master@{#26741}

[loislo, 2015-02-18 18:10:56]

loislo@chromium.org changed reviewers:
+ svenpanne@chromium.org, vegorov@chromium.org, yurys@chromium.org

[loislo, 2015-02-18 18:10:56]

PTAL

[loislo, 2015-02-18 18:17:16]

On 2015/02/18 18:10:56, loislo wrote:
> PTAL

the stack trace

#
# Fatal error in .././src/utils.h, line 220
# Check failed: is_valid(value).
#

==== C stack trace ===============================

 1: V8_Fatal
 2: v8::internal::BitFieldBase<unsigned int, 9, 23, unsigned
int>::encode(unsigned int)
 3: v8::internal::BitFieldBase<unsigned int, 9, 23, unsigned
int>::update(unsigned int, unsigned int)
 4: v8::internal::SourcePosition::set_position(unsigned int)
 5: v8::internal::HGraphBuilder::ScriptPositionToSourcePosition(int)
 6:
v8::internal::HOptimizedGraphBuilder::VisitCompareOperation(v8::internal::CompareOperation*)
 7:
v8::internal::HOptimizedGraphBuilderWithPositions::VisitCompareOperation(v8::internal::CompareOperation*)
 8: non-virtual thunk to
v8::internal::HOptimizedGraphBuilderWithPositions::VisitCompareOperation(v8::internal::CompareOperation*)
 9: v8::internal::CompareOperation::Accept(v8::internal::AstVisitor*)

[yurys, 2015-02-19 09:13:52]

lgtm

https://codereview.chromium.org/940593002/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/940593002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1789: v8::Local<v8::Context> env =
CcTest::NewContext(PROFILER_EXTENSION);
This line can be removed.

https://codereview.chromium.org/940593002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1792:
printf("--------------start--------------\n");
And this.

[loislo, 2015-02-19 09:22:15]

New patchsets have been uploaded after l-g-t-m from yurys@chromium.org

[loislo, 2015-02-19 09:31:51]

done

[marja, 2015-02-19 10:01:54]

marja@chromium.org changed reviewers:
+ marja@chromium.org

[marja, 2015-02-19 10:01:55]

lgtm; seems sensemaking to add the position if it fixes something :)

[loislo, 2015-02-19 10:02:42]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2015-02-19 10:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/940593002/20001

[commit-bot: I haz the power, 2015-02-19 10:07:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 10:08:05]

Patchset 2 (id:??) landed as
https://crrev.com/36ed9ca348a6d89a35e966db1b8ae77b2ac176a0
Cr-Commit-Position: refs/heads/master@{#26741}