Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 940563002: Update DirectWrite streams to SkStreamAsset. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update DirectWrite streams to SkStreamAsset. SkTypefaces now deal in terms of SkStreamAsset, but the DirectWrite port was never fully converted. Committed: https://skia.googlesource.com/skia/+/0babd3c61987428a5c532f65be9d98c7ac583e0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/ports/SkFontMgr_win_dw.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils/win/SkDWriteFontFileStream.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/utils/win/SkDWriteFontFileStream.cpp View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
5 years, 10 months ago (2015-02-18 17:39:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940563002/1
5 years, 10 months ago (2015-02-18 17:39:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-18 17:39:51 UTC) #5
mtklein
lgtm
5 years, 10 months ago (2015-02-18 18:42:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 19:01:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0babd3c61987428a5c532f65be9d98c7ac583e0d

Powered by Google App Engine
This is Rietveld 408576698