Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 940483002: Fix JSObjectFieldAccessor support in crankshaft (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSObjectFieldAccessor support in crankshaft BUG=459459 LOG=n Committed: https://crrev.com/79888090c89706d62913d278d11a7d392f89fd16 Cr-Commit-Position: refs/heads/master@{#26716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/hydrogen.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-18 10:54:25 UTC) #2
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-18 10:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940483002/1
5 years, 10 months ago (2015-02-18 10:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 11:18:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 11:18:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79888090c89706d62913d278d11a7d392f89fd16
Cr-Commit-Position: refs/heads/master@{#26716}

Powered by Google App Engine
This is Rietveld 408576698