Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 940443002: Pass original int64 response time when caching resource metadata. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pass original int64 response time when caching resource metadata. This is part 3/4 of a clean up to switch to int64 time stamps when caching metadata. The background to this is that converting int64 time stamps to double and back to int64 is lossy and causes false time stamp mismatches. BUG=453298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190618

Patch Set 1 #

Patch Set 2 : remove old cacheMetadata #

Patch Set 3 : addressed comments #

Patch Set 4 : rename #

Patch Set 5 : rebase #

Patch Set 6 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M Source/core/fetch/ResourceTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebURLResponse.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/network/ResourceResponse.h View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M Source/platform/network/ResourceResponse.cpp View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M public/platform/Platform.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebURLResponse.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
Please take a look. This is part of a series of CLs between blink and ...
5 years, 10 months ago (2015-02-18 09:47:03 UTC) #2
Yang
Updated to reflect changes in part 1.
5 years, 10 months ago (2015-02-19 08:40:38 UTC) #3
Mike West
LGTM.
5 years, 10 months ago (2015-02-19 09:37:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940443002/80001
5 years, 10 months ago (2015-02-20 22:27:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/29016)
5 years, 10 months ago (2015-02-20 23:15:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940443002/80001
5 years, 10 months ago (2015-02-21 07:12:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/46292)
5 years, 10 months ago (2015-02-21 08:25:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940443002/100001
5 years, 10 months ago (2015-02-21 08:51:30 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 10:08:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190618

Powered by Google App Engine
This is Rietveld 408576698