[DevTools] Teach MediaQueryInspector about disabling models while profiling.

Source/devtools/front_end/toolbox/MediaQueryInspector.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.View}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.MediaQueryInspector = function()
 {
     WebInspector.View.call(this);
     this.element.classList.add("media-inspector-view", "media-inspector-view-empty");
     this.element.addEventListener("click", this._onMediaQueryClicked.bind(this), false);
     this.element.addEventListener("contextmenu", this._onContextMenu.bind(this), false);
     this._mediaThrottler = new WebInspector.Throttler(0);
 
     this._offset = 0;
     this._scale = 1;
     this._lastReportedCount = 0;
+    this._canRevealSourceLocation = false;

[lushnikov, 2015/02/25 15:23:55]

сan we have method _canRevealSourceLocation that would just return
target.cssModel.isEnabled()? We will avoid all the hustle with variable
updating.

[dgozman, 2015/02/25 15:51:55]

Done.

 
     WebInspector.targetManager.observeTargets(this);
 
     WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.ZoomChanged, this._renderMediaQueries.bind(this), this);
 }
 
 /**
  * @enum {number}
  */
 WebInspector.MediaQueryInspector.Section = {
@@ skipping 11 matching lines @@
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target)
     {
         // FIXME: adapt this to multiple targets.
         if (this._target)
             return;
         this._target = target;
+        this._canRevealSourceLocation = target.cssModel.isEnabled();
         target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetRemoved, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this._scheduleMediaQueriesUpdate, this);
+        target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.ModelWasDisabled, this._cssModelEnabledChanged, this);
+        target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.ModelWasEnabled, this._cssModelEnabledChanged, this);
     },
 
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target)
     {
         if (target !== this._target)
             return;
         target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetRemoved, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this._scheduleMediaQueriesUpdate, this);
         target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this._scheduleMediaQueriesUpdate, this);
+        target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.ModelWasDisabled, this._cssModelEnabledChanged, this);
+        target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.ModelWasEnabled, this._cssModelEnabledChanged, this);
+        this._canRevealSourceLocation = false;
+        delete this._target;
     },
 
     /**
      * @param {number} offset
      * @param {number} scale
      */
     setAxisTransform: function(offset, scale)
     {
         if (this._offset === offset && Math.abs(this._scale - scale) < 1e-8)
             return;
@@ skipping 43 matching lines @@
             setWidth(model.minWidthExpression().computedLength());
         else
             setWidth(model.maxWidthExpression().computedLength());
     },
 
     /**
      * @param {!Event} event
      */
     _onContextMenu: function(event)
     {
+        if (!this._canRevealSourceLocation)
+            return;
+
         var mediaQueryMarker = event.target.enclosingNodeOrSelfWithClass("media-inspector-marker");
         if (!mediaQueryMarker)
             return;
 
         var locations = mediaQueryMarker._locations;
         var uiLocations = new Map();
         for (var i = 0; i < locations.length; ++i) {
             var uiLocation = WebInspector.cssWorkspaceBinding.rawLocationToUILocation(locations[i]);
             if (!uiLocation)
                 continue;
             var descriptor = String.sprintf("%s:%d:%d", uiLocation.uiSourceCode.uri(), uiLocation.lineNumber + 1, uiLocation.columnNumber + 1);
             uiLocations.set(descriptor, uiLocation);
         }
 
         var contextMenuItems = uiLocations.keysArray().sort();
         var contextMenu = new WebInspector.ContextMenu(event);
         var subMenuItem = contextMenu.appendSubMenuItem(WebInspector.UIString.capitalize("Reveal in ^source ^code"));
         for (var i = 0; i < contextMenuItems.length; ++i) {
             var title = contextMenuItems[i];
             subMenuItem.appendItem(title, this._revealSourceLocation.bind(this, /** @type {!WebInspector.UILocation} */(uiLocations.get(title))));
         }
         contextMenu.show();
     },
 
+    _cssModelEnabledChanged: function()
+    {
+        if (this._target)
+            this._canRevealSourceLocation = this._target.cssModel.isEnabled();

[caseq, 2015/02/25 14:58:34]

Why not just check the model state upon onContextMenu?

[dgozman, 2015/02/25 15:51:55]

Done.

+    },
+
     /**
      * @param {!WebInspector.UILocation} location
      */
     _revealSourceLocation: function(location)
     {
         WebInspector.Revealer.reveal(location);
     },
 
     _scheduleMediaQueriesUpdate: function()
     {
         if (!this._enabled)
             return;
         this._mediaThrottler.schedule(this._refetchMediaQueries.bind(this));
     },
 
     /**
      * @param {!WebInspector.Throttler.FinishCallback} finishCallback
      */
     _refetchMediaQueries: function(finishCallback)
     {
-        if (!this._enabled) {
+        if (!this._enabled || !this._target) {
             finishCallback();
             return;
         }
 
         /**
          * @param {!Array.<!WebInspector.CSSMedia>} cssMedias
          * @this {!WebInspector.MediaQueryInspector}
          */
         function callback(cssMedias)
         {
@@ skipping 313 matching lines @@
     },
 
     /**
      * @return {boolean}
      */
     active: function()
     {
         return this._active;
     }
 }