Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940373004: [DevTools] Teach MediaQueryInspector about disabling models while profiling. (Closed)

Created:
5 years, 10 months ago by dgozman
Modified:
5 years, 10 months ago
Reviewers:
caseq, lushnikov
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Teach MediaQueryInspector about disabling models while profiling. BUG=461810 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190855

Patch Set 1 #

Patch Set 2 : more cleanup #

Total comments: 6

Patch Set 3 : simplified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/toolbox/MediaQueryInspector.js View 1 2 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dgozman
Take a look please.
5 years, 10 months ago (2015-02-25 14:45:57 UTC) #2
caseq
https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/toolbox/MediaQueryInspector.js File Source/devtools/front_end/toolbox/MediaQueryInspector.js (right): https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/toolbox/MediaQueryInspector.js#newcode171 Source/devtools/front_end/toolbox/MediaQueryInspector.js:171: this._canRevealSourceLocation = this._target.cssModel.isEnabled(); Why not just check the model ...
5 years, 10 months ago (2015-02-25 14:58:34 UTC) #3
lushnikov
https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/sdk/CSSStyleModel.js File Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode93 Source/devtools/front_end/sdk/CSSStyleModel.js:93: this._resetStyleSheets(); why this change? https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/toolbox/MediaQueryInspector.js File Source/devtools/front_end/toolbox/MediaQueryInspector.js (right): https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/toolbox/MediaQueryInspector.js#newcode21 ...
5 years, 10 months ago (2015-02-25 15:23:55 UTC) #4
dgozman
PTAL https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/sdk/CSSStyleModel.js File Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/940373004/diff/20001/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode93 Source/devtools/front_end/sdk/CSSStyleModel.js:93: this._resetStyleSheets(); On 2015/02/25 15:23:55, lushnikov wrote: > why ...
5 years, 10 months ago (2015-02-25 15:51:55 UTC) #5
caseq
lgtm
5 years, 10 months ago (2015-02-25 16:45:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940373004/40001
5 years, 10 months ago (2015-02-25 18:23:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:38:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190855

Powered by Google App Engine
This is Rietveld 408576698