[Telemetry] Don't display "Locals:" header if there are no locals to print.

[Telemetry] Don't display "Locals:" header if there are no locals to print.

Doing the 'self' exclusion in the loop was too late.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238192

[dtu, 2013-12-02 18:43:42]

https://codereview.chromium.org/94033003/diff/1/tools/telemetry/telemetry/exc...
File tools/telemetry/telemetry/exception_formatter.py (right):

https://codereview.chromium.org/94033003/diff/1/tools/telemetry/telemetry/exc...
tools/telemetry/telemetry/exception_formatter.py:65: del local_variables['self']
Shouldn't this go inside the if statement? Also you should make a copy rather
than modifying the original?

[tonyg, 2013-12-02 19:03:23]

On 2013/12/02 18:43:42, dtu wrote:
>
https://codereview.chromium.org/94033003/diff/1/tools/telemetry/telemetry/exc...
> File tools/telemetry/telemetry/exception_formatter.py (right):
> 
>
https://codereview.chromium.org/94033003/diff/1/tools/telemetry/telemetry/exc...
> tools/telemetry/telemetry/exception_formatter.py:65: del
local_variables['self']
> Shouldn't this go inside the if statement? Also you should make a copy rather
> than modifying the original?

How about this approach? I verified that it works when there are no locals as
well.

def Foo():
  assert False
Foo()

[dtu, 2013-12-02 19:21:40]

lgtm

[commit-bot: I haz the power, 2013-12-02 19:23:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/94033003/20001

[commit-bot: I haz the power, 2013-12-02 21:44:44]

Change committed as 238192