Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: mojo/services/gpu/public/interfaces/gpu.mojom

Issue 940293003: Add a Display and ContextProvider concept to mojom, use to recreate (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/gpu/public/interfaces/gpu.mojom
diff --git a/mojo/services/gpu/public/interfaces/gpu.mojom b/mojo/services/gpu/public/interfaces/gpu.mojom
index c61869c8921aedbf100a4dad5dd79eb3476278e5..5f8a0b49595b10d3e3d541bbacffc9b729719bdf 100644
--- a/mojo/services/gpu/public/interfaces/gpu.mojom
+++ b/mojo/services/gpu/public/interfaces/gpu.mojom
@@ -9,9 +9,22 @@ import "gpu/public/interfaces/command_buffer.mojom";
import "gpu/public/interfaces/viewport_parameter_listener.mojom";
interface Gpu {
- CreateOnscreenGLES2Context(uint64 native_viewport_id,
- Size size,
- CommandBuffer& gles2_client,
- ViewportParameterListener? listener);
+ // Creates a new offscreen OpenGL ES 2.0 context.
CreateOffscreenGLES2Context(CommandBuffer& gles2_client);
};
+
+// A ContextProvider can be used to provide new command buffers related to a
+// particular context, for instance configured to draw to a particular display.
+interface ContextProvider {
+ // This initializes a new command buffer for this provider when available,
+ // closing connections to the previously created command buffer (if any).
+ //
+ // This call may not return for an extended period of time if a command
+ // buffer cannot be produced immediately, for example if it is associated
+ // with a view that is offscreen.
+ //
+ // If a viewport_parameter_listener is provided it will be when vsync
qsr 2015/02/20 11:25:47 It seems you are missing some part of this sentenc
jamesr 2015/02/20 22:01:05 Done.
+ // parameters change for this context.
+ Create(ViewportParameterListener? viewport_parameter_listener)
+ => (CommandBuffer? gles2_client);
+};

Powered by Google App Engine
This is Rietveld 408576698