Add a Display and ContextProvider concept to mojom, use to recreate

services/native_viewport/native_viewport_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/native_viewport/native_viewport_impl.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/input_events/input_events_type_converters.h"
-#include "mojo/converters/surfaces/surfaces_type_converters.h"
-#include "mojo/public/cpp/application/application_delegate.h"
-#include "mojo/public/cpp/application/application_impl.h"
 #include "mojo/public/cpp/application/interface_factory.h"
+#include "services/gles2/gpu_state.h"
 #include "services/native_viewport/platform_viewport_headless.h"
-#include "services/native_viewport/viewport_surface.h"
 #include "ui/events/event.h"
 
 namespace native_viewport {
 namespace {
 
 bool IsRateLimitedEventType(ui::Event* event) {
   return event->type() == ui::ET_MOUSE_MOVED ||
          event->type() == ui::ET_MOUSE_DRAGGED ||
          event->type() == ui::ET_TOUCH_MOVED;
 }
 
 }  // namespace
 
 NativeViewportImpl::NativeViewportImpl(
-    mojo::ApplicationImpl* app,
     bool is_headless,
+    const scoped_refptr<gles2::GpuState>& gpu_state,
     mojo::InterfaceRequest<mojo::NativeViewport> request)
     : is_headless_(is_headless),
-      widget_id_(0u),
+      context_provider_(gpu_state),
       sent_metrics_(false),
       metrics_(mojo::ViewportMetrics::New()),
       waiting_for_event_ack_(false),
       binding_(this, request.Pass()),
       weak_factory_(this) {
   binding_.set_error_handler(this);
-  app->ConnectToService("mojo:surfaces_service", &surface_);
-  // TODO(jamesr): Should be mojo_gpu_service
-  app->ConnectToService("mojo:native_viewport_service", &gpu_service_);
 }
 
 NativeViewportImpl::~NativeViewportImpl() {
   // Destroy the NativeViewport early on as it may call us back during
   // destruction and we want to be in a known state.
   platform_viewport_.reset();
 }
 
-void NativeViewportImpl::Create(
-    mojo::SizePtr size,
-    const mojo::Callback<void(uint64_t, mojo::ViewportMetricsPtr metrics)>&
-        callback) {
+void NativeViewportImpl::Create(mojo::SizePtr size,
+                                const CreateCallback& callback) {
   create_callback_ = callback;
   metrics_->size = size.Clone();
   if (is_headless_)
     platform_viewport_ = PlatformViewportHeadless::Create(this);
   else
     platform_viewport_ = PlatformViewport::Create(this);
   platform_viewport_->Init(gfx::Rect(size.To<gfx::Size>()));
 }
 
-void NativeViewportImpl::RequestMetrics(const MetricsCallback& callback) {
+void NativeViewportImpl::RequestMetrics(
+    const RequestMetricsCallback& callback) {
   if (!sent_metrics_) {
     callback.Run(metrics_.Clone());
     sent_metrics_ = true;
     return;
   }
   metrics_callback_ = callback;
 }
 
 void NativeViewportImpl::Show() {
   platform_viewport_->Show();
 }
 
 void NativeViewportImpl::Hide() {
   platform_viewport_->Hide();
 }
 
 void NativeViewportImpl::Close() {
   DCHECK(platform_viewport_);
   platform_viewport_->Close();
 }
 
 void NativeViewportImpl::SetSize(mojo::SizePtr size) {
   platform_viewport_->SetBounds(gfx::Rect(size.To<gfx::Size>()));
 }
 
-void NativeViewportImpl::SubmittedFrame(mojo::SurfaceIdPtr child_surface_id) {
-  if (child_surface_id_.is_null()) {
-    // If this is the first indication that the client will use surfaces,
-    // initialize that system.
-    // TODO(jamesr): When everything is converted to surfaces initialize this
-    // eagerly.
-    viewport_surface_.reset(new ViewportSurface(
-        surface_.Pass(), gpu_service_.get(), metrics_->size.To<gfx::Size>(),
-        child_surface_id.To<cc::SurfaceId>()));
-    if (widget_id_)
-      viewport_surface_->SetWidgetId(widget_id_);
-  }
-  child_surface_id_ = child_surface_id.To<cc::SurfaceId>();
-  if (viewport_surface_)
-    viewport_surface_->SetChildId(child_surface_id_);
+void NativeViewportImpl::GetContextProvider(
+    mojo::InterfaceRequest<mojo::ContextProvider> request) {
+  context_provider_.Bind(request.Pass());
 }
 
 void NativeViewportImpl::SetEventDispatcher(
     mojo::NativeViewportEventDispatcherPtr dispatcher) {
   event_dispatcher_ = dispatcher.Pass();
 }
 
 void NativeViewportImpl::OnMetricsChanged(mojo::ViewportMetricsPtr metrics) {
   if (metrics_->Equals(*metrics))
     return;
 
   metrics_ = metrics.Pass();
   sent_metrics_ = false;
 
   if (!metrics_callback_.is_null()) {
     metrics_callback_.Run(metrics_.Clone());
     metrics_callback_.reset();
     sent_metrics_ = true;
   }
-  if (viewport_surface_)
-    viewport_surface_->SetSize(metrics_->size.To<gfx::Size>());
 }
 
 void NativeViewportImpl::OnAcceleratedWidgetAvailable(

[qsr, 2015/03/04 10:33:18]

You need to add another method notifying you of the lost of the widget, and you
need to call this, on android, from PlatformViewportAndroid::SurfaceDestroyed

[jamesr, 2015/03/04 23:00:27]

What do mean by "need to"?  The previous code didn't have any mechanism for this
so I don't see why adding something new is necessary for this patch.  Adding
additional hooks for new functionality should be in a separate patch.

[qsr, 2015/03/04 23:22:29]

 I mean that until now, returning from the background on android for the
spinning cube showed a black screen. After this change, it will crash. This is
because you changed the app to request a new context  when it losts its original
one, but you didn't made this class aware that the widget is not valid anymore,
so it will gladly create a context that reference a dangling pointer. Given that
a black screen is not much better than a crash, we can wait for a follow-up CL
to solve this, but this is still a regression in behavior.

     gfx::AcceleratedWidget widget) {
-  widget_id_ = static_cast<uint64_t>(bit_cast<uintptr_t>(widget));
-  // TODO(jamesr): Remove once everything is converted to surfaces.
-  create_callback_.Run(widget_id_, metrics_.Clone());
+  context_provider_.SetAcceleratedWidget(widget);
+  // TODO: The metrics here might not match the actual window size on android
+  // where we don't know the actual size until the first OnMetricsChanged call.
+  create_callback_.Run(metrics_.Clone());
   sent_metrics_ = true;
   create_callback_.reset();
-  if (viewport_surface_)
-    viewport_surface_->SetWidgetId(widget_id_);
 }
 
 bool NativeViewportImpl::OnEvent(ui::Event* ui_event) {
   if (!event_dispatcher_.get())
     return false;
 
   // Must not return early before updating capture.
   switch (ui_event->type()) {
     case ui::ET_MOUSE_PRESSED:
     case ui::ET_TOUCH_PRESSED:
@@ skipping 25 matching lines @@
 void NativeViewportImpl::OnConnectionError() {
   binding_.set_error_handler(nullptr);
   delete this;
 }
 
 void NativeViewportImpl::AckEvent() {
   waiting_for_event_ack_ = false;
 }
 
 }  // namespace native_viewport