Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 940293002: InlinedVisitor: Migrate templated classes in bindings/ manually to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate templated classes in bindings/ manually to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ Note to reviewers: This CL is created manually, as DEFINE_TRACE macros doesn't support template methods. R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190719

Patch Set 1 #

Patch Set 2 : compile fix #

Total comments: 2

Patch Set 3 : remove line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -33 lines) Patch
M Source/bindings/core/v8/ScriptPromiseProperty.h View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8DataView.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestException.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceDocument.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEmpty.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-20 02:14:10 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-20 03:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940293002/1
5 years, 10 months ago (2015-02-20 03:23:39 UTC) #6
yhirano
Do you need updating the following files? - bindings/templates/callback_interface.cpp - bindings/templates/dictionary_impl.cpp - bindings/templates/dictionary_impl.h - bindings/templates/union.cpp ...
5 years, 10 months ago (2015-02-20 03:27:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/35808)
5 years, 10 months ago (2015-02-20 03:36:31 UTC) #9
kouhei (in TOK)
> intentionally exclude these files because they can be automatically > updated? If so, it's ...
5 years, 10 months ago (2015-02-20 03:46:42 UTC) #10
yhirano
On 2015/02/20 03:46:42, kouhei wrote: > > intentionally exclude these files because they can be ...
5 years, 10 months ago (2015-02-20 04:22:14 UTC) #11
kouhei (in TOK)
On 2015/02/20 04:22:14, yhirano wrote: > On 2015/02/20 03:46:42, kouhei wrote: > > > intentionally ...
5 years, 10 months ago (2015-02-24 01:29:26 UTC) #12
yhirano
lgtm https://codereview.chromium.org/940293002/diff/20001/Source/bindings/core/v8/ScriptPromiseProperty.h File Source/bindings/core/v8/ScriptPromiseProperty.h (right): https://codereview.chromium.org/940293002/diff/20001/Source/bindings/core/v8/ScriptPromiseProperty.h#newcode168 Source/bindings/core/v8/ScriptPromiseProperty.h:168: An unnecessary empty line
5 years, 10 months ago (2015-02-24 04:30:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940293002/40001
5 years, 10 months ago (2015-02-24 04:35:55 UTC) #16
kouhei (in TOK)
https://codereview.chromium.org/940293002/diff/20001/Source/bindings/core/v8/ScriptPromiseProperty.h File Source/bindings/core/v8/ScriptPromiseProperty.h (right): https://codereview.chromium.org/940293002/diff/20001/Source/bindings/core/v8/ScriptPromiseProperty.h#newcode168 Source/bindings/core/v8/ScriptPromiseProperty.h:168: On 2015/02/24 04:30:19, yhirano wrote: > An unnecessary empty ...
5 years, 10 months ago (2015-02-24 04:37:15 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190719
5 years, 10 months ago (2015-02-24 07:16:43 UTC) #18
haraken
5 years, 10 months ago (2015-02-24 08:43:41 UTC) #19
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698