Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 940283007: Re-enable memory.top_7_stress test now that bug 455349 is fixed. (Closed)

Created:
5 years, 10 months ago by sullivan
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable memory.top_7_stress test now that bug 455349 is fixed. BUG=459646 Committed: https://crrev.com/92fb7ce426ebe966630fbd0de62e59cee91a6e74 Cr-Commit-Position: refs/heads/master@{#317606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
sullivan
5 years, 10 months ago (2015-02-20 20:17:59 UTC) #2
petrcermak
LGTM. Thanks :-)
5 years, 10 months ago (2015-02-23 10:10:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940283007/1
5 years, 10 months ago (2015-02-23 14:51:26 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-23 14:51:28 UTC) #7
Primiano Tucci (use gerrit)
lgtm
5 years, 10 months ago (2015-02-23 15:06:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940283007/1
5 years, 10 months ago (2015-02-23 15:15:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 18:20:49 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/92fb7ce426ebe966630fbd0de62e59cee91a6e74 Cr-Commit-Position: refs/heads/master@{#317606}
5 years, 10 months ago (2015-02-23 18:21:46 UTC) #13
sullivan
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/942113005/ by sullivan@chromium.org. ...
5 years, 10 months ago (2015-02-23 22:28:21 UTC) #14
Ilya Sherman
5 years, 10 months ago (2015-02-23 23:04:02 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/951683003/ by isherman@chromium.org.

The reason for reverting is: This is failing on the bots.  Sample failure:
http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%283%29/b...

[ RUN      ] Facebook
INFO:root:Loading http://www.facebook.com/...
WARNING:root:Timed out while loading: http://www.facebook.com/
Traceback (most recent call last):
  File "...\telemetry\telemetry\user_story\user_story_runner.py", line 100, in
_RunUserStoryAndProcessErrorIfNeeded
    state.RunUserStory(results)
  File "...\telemetry\telemetry\page\shared_page_state.py", line 240, in
RunUserStory
    self._PreparePage()
  File "...\telemetry\telemetry\page\shared_page_state.py", line 223, in
_PreparePage
    'Login as ' + self._current_page.credentials + ' failed')
Failure: Login as facebook failed

[ ... ]

[  FAILED  ] Facebook (60937 ms).

Powered by Google App Engine
This is Rietveld 408576698