Issue 940283002: [SVGDevice] Text whitespace unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940283002: [SVGDevice] Text whitespace unittest (Closed)

Created:
5 years, 10 months ago by f(malita)

Modified:
5 years, 10 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

[SVGDevice] Text whitespace unittest Plumb SkDOM as needed to make it suitable for an SkXMLWriter backend. Also fix a potential null typeface issue in SkSVGDevice::AutoElement::addTextAttributes(). R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/7a048690d3cb6b3c1bdef594c3bd4b66f6b400c1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -60 lines)			Patch
M	gyp/tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/xml/SkDOM.h	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	src/svg/SkSVGDevice.cpp	View	1	2 chunks	+11 lines, -9 lines	0 comments	Download
M	src/xml/SkDOM.cpp	View	1 2	9 chunks	+60 lines, -48 lines	0 comments	Download
M	src/xml/SkXMLWriter.cpp	View		1 chunk	+8 lines, -1 line	0 comments	Download
A	tests/SVGDeviceTest.cpp	View	1 2 3	1 chunk	+149 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

f(malita)

This is quite contrived, because AFAICT we don't have a way to parse/import XML (SkXMLParser ...

5 years, 10 months ago (2015-02-20 02:30:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940283002/50001

5 years, 10 months ago (2015-02-20 21:49:03 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-20 21:54:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/7a048690d3cb6b3c1bdef594c3bd4b66f6b400c1