Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 940233002: Dart version of the Sky color chooser (Closed)

Created:
5 years, 10 months ago by hansmuller
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart version of the Sky color chooser I haven't removed the JS color picker code yet. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/77b1653e18b651d8bc8815538756fe9e98f4bbbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A sky/examples/color/color-chooser.sky View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hansmuller1
PTAL
5 years, 10 months ago (2015-02-19 23:04:29 UTC) #3
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-19 23:07:00 UTC) #4
hansmuller
5 years, 10 months ago (2015-02-19 23:08:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77b1653e18b651d8bc8815538756fe9e98f4bbbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698