Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 940223002: [Ozone-Dri] Make GbmWrapper destructor private (Closed)

Created:
5 years, 10 months ago by vignatti (out of this project)
Modified:
5 years, 10 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Dri] Make GbmWrapper destructor private It fixes the following clang format: In file included from ../../ui/ozone/platform/dri/gbm_surface.cc:14: ../../ui/ozone/platform/dri/gbm_wrapper.h:18:3: error: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. ~GbmWrapper() override; ^ ../../ui/ozone/platform/dri/gbm_wrapper.h:14:20: note: [chromium-style] 'GbmWrapper' inherits from 'ui::DriWrapper' here class GbmWrapper : public DriWrapper { ^ ../../ui/ozone/platform/dri/dri_wrapper.h:41:33: note: [chromium-style] 'DriWrapper' inherits from 'base::RefCountedThreadSafe<DriWrapper>' here class OZONE_EXPORT DriWrapper : public base::RefCountedThreadSafe<DriWrapper> { ^ BUG=none Committed: https://crrev.com/34108a53235e8c61d625ad80db7941edf1684084 Cr-Commit-Position: refs/heads/master@{#317300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/ozone/platform/dri/gbm_wrapper.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vignatti (out of this project)
dnicoara@ PTAL.
5 years, 10 months ago (2015-02-19 22:30:02 UTC) #2
spang
lgtm
5 years, 10 months ago (2015-02-19 23:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940223002/1
5 years, 10 months ago (2015-02-20 12:15:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 12:35:32 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 12:36:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34108a53235e8c61d625ad80db7941edf1684084
Cr-Commit-Position: refs/heads/master@{#317300}

Powered by Google App Engine
This is Rietveld 408576698