Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 940183002: [NaCl SDK] Add arm-nacl-clang support to the SDK (Closed)

Created:
5 years, 10 months ago by Sam Clegg
Modified:
5 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add arm-nacl-clang support to the SDK Currently (as with arm-nacl-gcc) there is no testing done using the produced binaries. I'm working on change to at least do testing on linux used qemu-arm + sel_lr. R=binji BUG=454962 Committed: https://crrev.com/cfcda7eb992c2f6fbd97633ffdf3b5e475ac268b Cr-Commit-Position: refs/heads/master@{#317261}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 4 chunks +9 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M native_client_sdk/src/tools/nacl_config.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Sam Clegg
5 years, 10 months ago (2015-02-19 21:51:16 UTC) #1
binji
lgtm
5 years, 10 months ago (2015-02-19 23:04:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940183002/40001
5 years, 10 months ago (2015-02-20 02:01:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/10228) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-20 02:07:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940183002/40001
5 years, 10 months ago (2015-02-20 06:35:34 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 06:52:23 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 06:52:56 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cfcda7eb992c2f6fbd97633ffdf3b5e475ac268b
Cr-Commit-Position: refs/heads/master@{#317261}

Powered by Google App Engine
This is Rietveld 408576698