Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Side by Side Diff: chrome/installer/util/uninstall_metrics.h

Issue 94013004: Add base:: to string16s in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try again Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_ 5 #ifndef CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_
6 #define CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_ 6 #define CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 9
10 namespace base { 10 namespace base {
11 class DictionaryValue; 11 class DictionaryValue;
12 class FilePath; 12 class FilePath;
13 } 13 }
14 14
15 namespace installer { 15 namespace installer {
16 16
17 // Extracts uninstall metrics from the given JSON value. 17 // Extracts uninstall metrics from the given JSON value.
18 bool ExtractUninstallMetrics(const base::DictionaryValue& root, 18 bool ExtractUninstallMetrics(const base::DictionaryValue& root,
19 string16* uninstall_metrics); 19 base::string16* uninstall_metrics);
20 20
21 // Extracts uninstall metrics from the JSON file located at file_path. 21 // Extracts uninstall metrics from the JSON file located at file_path.
22 // Returns them in a form suitable for appending to a url that already 22 // Returns them in a form suitable for appending to a url that already
23 // has GET parameters, i.e. &metric1=foo&metric2=bar. 23 // has GET parameters, i.e. &metric1=foo&metric2=bar.
24 // Returns true if uninstall_metrics has been successfully populated with 24 // Returns true if uninstall_metrics has been successfully populated with
25 // the uninstall metrics, false otherwise. 25 // the uninstall metrics, false otherwise.
26 bool ExtractUninstallMetricsFromFile(const base::FilePath& file_path, 26 bool ExtractUninstallMetricsFromFile(const base::FilePath& file_path,
27 string16* uninstall_metrics); 27 base::string16* uninstall_metrics);
28 28
29 } // namespace installer 29 } // namespace installer
30 30
31 #endif // CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_ 31 #endif // CHROME_INSTALLER_UTIL_UNINSTALL_METRICS_H_
OLDNEW
« no previous file with comments | « chrome/installer/util/shell_util_unittest.cc ('k') | chrome/installer/util/uninstall_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698