Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/installer/gcapi/gcapi_omaha_experiment_test.cc

Issue 94013004: Add base:: to string16s in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try again Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/gcapi/gcapi_omaha_experiment.h" 5 #include "chrome/installer/gcapi/gcapi_omaha_experiment.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/installer/gcapi/gcapi.h" 8 #include "chrome/installer/gcapi/gcapi.h"
9 #include "chrome/installer/gcapi/gcapi_test_registry_overrider.h" 9 #include "chrome/installer/gcapi/gcapi_test_registry_overrider.h"
10 #include "chrome/installer/util/google_update_constants.h" 10 #include "chrome/installer/util/google_update_constants.h"
(...skipping 13 matching lines...) Expand all
24 class GCAPIOmahaExperimentTest : public ::testing::Test { 24 class GCAPIOmahaExperimentTest : public ::testing::Test {
25 protected: 25 protected:
26 GCAPIOmahaExperimentTest() 26 GCAPIOmahaExperimentTest()
27 : brand_(kBrand), 27 : brand_(kBrand),
28 reactivation_label_(gcapi_internals::GetGCAPIExperimentLabel( 28 reactivation_label_(gcapi_internals::GetGCAPIExperimentLabel(
29 kBrand, gcapi_internals::kReactivationLabel)), 29 kBrand, gcapi_internals::kReactivationLabel)),
30 relaunch_label_(gcapi_internals::GetGCAPIExperimentLabel( 30 relaunch_label_(gcapi_internals::GetGCAPIExperimentLabel(
31 kBrand, gcapi_internals::kRelaunchLabel)) { 31 kBrand, gcapi_internals::kRelaunchLabel)) {
32 } 32 }
33 33
34 void VerifyExperimentLabels(const string16& expected_labels) { 34 void VerifyExperimentLabels(const base::string16& expected_labels) {
35 string16 actual_labels; 35 base::string16 actual_labels;
36 EXPECT_TRUE(GoogleUpdateSettings::ReadExperimentLabels(false, 36 EXPECT_TRUE(GoogleUpdateSettings::ReadExperimentLabels(false,
37 &actual_labels)); 37 &actual_labels));
38 EXPECT_EQ(expected_labels, actual_labels); 38 EXPECT_EQ(expected_labels, actual_labels);
39 } 39 }
40 40
41 string16 brand_; 41 base::string16 brand_;
42 string16 reactivation_label_; 42 base::string16 reactivation_label_;
43 string16 relaunch_label_; 43 base::string16 relaunch_label_;
44 44
45 const GCAPITestRegistryOverrider gcapi_test_registry_overrider_; 45 const GCAPITestRegistryOverrider gcapi_test_registry_overrider_;
46 }; 46 };
47 47
48 TEST_F(GCAPIOmahaExperimentTest, SetReactivationLabelFromEmptyExperiments) { 48 TEST_F(GCAPIOmahaExperimentTest, SetReactivationLabelFromEmptyExperiments) {
49 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 49 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
50 VerifyExperimentLabels(reactivation_label_); 50 VerifyExperimentLabels(reactivation_label_);
51 } 51 }
52 52
53 // Test the relaunch label once; all other tests go more in depth, but since 53 // Test the relaunch label once; all other tests go more in depth, but since
54 // both labels use the same logic underneath there is no need to test both in 54 // both labels use the same logic underneath there is no need to test both in
55 // depth. 55 // depth.
56 TEST_F(GCAPIOmahaExperimentTest, SetRelaunchLabelFromEmptyExperiments) { 56 TEST_F(GCAPIOmahaExperimentTest, SetRelaunchLabelFromEmptyExperiments) {
57 ASSERT_TRUE(SetRelaunchExperimentLabels(kBrand, kUserLevel)); 57 ASSERT_TRUE(SetRelaunchExperimentLabels(kBrand, kUserLevel));
58 VerifyExperimentLabels(relaunch_label_); 58 VerifyExperimentLabels(relaunch_label_);
59 } 59 }
60 60
61 TEST_F(GCAPIOmahaExperimentTest, SetReactivationLabelWithExistingExperiments) { 61 TEST_F(GCAPIOmahaExperimentTest, SetReactivationLabelWithExistingExperiments) {
62 GoogleUpdateSettings::SetExperimentLabels(false, kSomeExperiments); 62 GoogleUpdateSettings::SetExperimentLabels(false, kSomeExperiments);
63 63
64 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 64 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
65 65
66 string16 expected_labels(kSomeExperiments); 66 base::string16 expected_labels(kSomeExperiments);
67 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 67 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
68 expected_labels.append(reactivation_label_); 68 expected_labels.append(reactivation_label_);
69 VerifyExperimentLabels(expected_labels); 69 VerifyExperimentLabels(expected_labels);
70 } 70 }
71 71
72 TEST_F(GCAPIOmahaExperimentTest, 72 TEST_F(GCAPIOmahaExperimentTest,
73 SetReactivationLabelWithExistingIdenticalExperiment) { 73 SetReactivationLabelWithExistingIdenticalExperiment) {
74 string16 previous_labels(kSomeExperiments); 74 base::string16 previous_labels(kSomeExperiments);
75 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 75 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
76 previous_labels.append(reactivation_label_); 76 previous_labels.append(reactivation_label_);
77 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 77 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
78 previous_labels.append(kSomeOtherExperiments); 78 previous_labels.append(kSomeOtherExperiments);
79 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels); 79 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels);
80 80
81 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 81 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
82 82
83 string16 expected_labels(kSomeExperiments); 83 base::string16 expected_labels(kSomeExperiments);
84 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 84 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
85 expected_labels.append(kSomeOtherExperiments); 85 expected_labels.append(kSomeOtherExperiments);
86 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 86 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
87 expected_labels.append(reactivation_label_); 87 expected_labels.append(reactivation_label_);
88 VerifyExperimentLabels(expected_labels); 88 VerifyExperimentLabels(expected_labels);
89 } 89 }
90 90
91 TEST_F(GCAPIOmahaExperimentTest, 91 TEST_F(GCAPIOmahaExperimentTest,
92 SetReactivationLabelWithExistingIdenticalAtBeginning) { 92 SetReactivationLabelWithExistingIdenticalAtBeginning) {
93 string16 previous_labels(reactivation_label_); 93 base::string16 previous_labels(reactivation_label_);
94 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 94 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
95 previous_labels.append(kSomeExperiments); 95 previous_labels.append(kSomeExperiments);
96 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels); 96 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels);
97 97
98 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 98 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
99 99
100 string16 expected_labels(kSomeExperiments); 100 base::string16 expected_labels(kSomeExperiments);
101 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 101 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
102 expected_labels.append(reactivation_label_); 102 expected_labels.append(reactivation_label_);
103 VerifyExperimentLabels(expected_labels); 103 VerifyExperimentLabels(expected_labels);
104 } 104 }
105 105
106 TEST_F(GCAPIOmahaExperimentTest, 106 TEST_F(GCAPIOmahaExperimentTest,
107 SetReactivationLabelWithFakeMatchInAnExperiment) { 107 SetReactivationLabelWithFakeMatchInAnExperiment) {
108 string16 previous_labels(kSomeExperiments); 108 base::string16 previous_labels(kSomeExperiments);
109 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 109 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
110 previous_labels.append(L"blah_"); 110 previous_labels.append(L"blah_");
111 // Shouldn't match deletion criteria. 111 // Shouldn't match deletion criteria.
112 previous_labels.append(reactivation_label_); 112 previous_labels.append(reactivation_label_);
113 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 113 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
114 previous_labels.append(kSomeOtherExperiments); 114 previous_labels.append(kSomeOtherExperiments);
115 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 115 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
116 // Should match the deletion criteria. 116 // Should match the deletion criteria.
117 previous_labels.append(reactivation_label_); 117 previous_labels.append(reactivation_label_);
118 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 118 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
119 previous_labels.append(kSomeMoreExperiments); 119 previous_labels.append(kSomeMoreExperiments);
120 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels); 120 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels);
121 121
122 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 122 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
123 123
124 string16 expected_labels(kSomeExperiments); 124 base::string16 expected_labels(kSomeExperiments);
125 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 125 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
126 expected_labels.append(L"blah_"); 126 expected_labels.append(L"blah_");
127 expected_labels.append(reactivation_label_); 127 expected_labels.append(reactivation_label_);
128 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 128 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
129 expected_labels.append(kSomeOtherExperiments); 129 expected_labels.append(kSomeOtherExperiments);
130 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 130 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
131 expected_labels.append(kSomeMoreExperiments); 131 expected_labels.append(kSomeMoreExperiments);
132 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 132 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
133 expected_labels.append(reactivation_label_); 133 expected_labels.append(reactivation_label_);
134 VerifyExperimentLabels(expected_labels); 134 VerifyExperimentLabels(expected_labels);
135 } 135 }
136 136
137 TEST_F(GCAPIOmahaExperimentTest, 137 TEST_F(GCAPIOmahaExperimentTest,
138 SetReactivationLabelWithFakeMatchInAnExperimentAndNoRealMatch) { 138 SetReactivationLabelWithFakeMatchInAnExperimentAndNoRealMatch) {
139 string16 previous_labels(kSomeExperiments); 139 base::string16 previous_labels(kSomeExperiments);
140 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 140 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
141 previous_labels.append(L"blah_"); 141 previous_labels.append(L"blah_");
142 // Shouldn't match deletion criteria. 142 // Shouldn't match deletion criteria.
143 previous_labels.append(reactivation_label_); 143 previous_labels.append(reactivation_label_);
144 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 144 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
145 previous_labels.append(kSomeOtherExperiments); 145 previous_labels.append(kSomeOtherExperiments);
146 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels); 146 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels);
147 147
148 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 148 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
149 149
150 string16 expected_labels(kSomeExperiments); 150 base::string16 expected_labels(kSomeExperiments);
151 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 151 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
152 expected_labels.append(L"blah_"); 152 expected_labels.append(L"blah_");
153 expected_labels.append(reactivation_label_); 153 expected_labels.append(reactivation_label_);
154 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 154 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
155 expected_labels.append(kSomeOtherExperiments); 155 expected_labels.append(kSomeOtherExperiments);
156 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 156 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
157 expected_labels.append(reactivation_label_); 157 expected_labels.append(reactivation_label_);
158 VerifyExperimentLabels(expected_labels); 158 VerifyExperimentLabels(expected_labels);
159 } 159 }
160 160
161 TEST_F(GCAPIOmahaExperimentTest, 161 TEST_F(GCAPIOmahaExperimentTest,
162 SetReactivationLabelWithExistingEntryWithLabelAsPrefix) { 162 SetReactivationLabelWithExistingEntryWithLabelAsPrefix) {
163 string16 previous_labels(kSomeExperiments); 163 base::string16 previous_labels(kSomeExperiments);
164 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 164 previous_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
165 // Append prefix matching the label, but not followed by '='. 165 // Append prefix matching the label, but not followed by '='.
166 previous_labels.append(gcapi_internals::kReactivationLabel); 166 previous_labels.append(gcapi_internals::kReactivationLabel);
167 // Shouldn't match deletion criteria. 167 // Shouldn't match deletion criteria.
168 previous_labels.append(kSomeOtherExperiments); 168 previous_labels.append(kSomeOtherExperiments);
169 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels); 169 GoogleUpdateSettings::SetExperimentLabels(false, previous_labels);
170 170
171 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel)); 171 ASSERT_TRUE(SetReactivationExperimentLabels(kBrand, kUserLevel));
172 172
173 string16 expected_labels(kSomeExperiments); 173 base::string16 expected_labels(kSomeExperiments);
174 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 174 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
175 expected_labels.append(gcapi_internals::kReactivationLabel); 175 expected_labels.append(gcapi_internals::kReactivationLabel);
176 expected_labels.append(kSomeOtherExperiments); 176 expected_labels.append(kSomeOtherExperiments);
177 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep)); 177 expected_labels.append(ASCIIToUTF16(google_update::kExperimentLabelSep));
178 expected_labels.append(reactivation_label_); 178 expected_labels.append(reactivation_label_);
179 VerifyExperimentLabels(expected_labels); 179 VerifyExperimentLabels(expected_labels);
180 } 180 }
181 181
182 } // namespace 182 } // namespace
OLDNEW
« no previous file with comments | « chrome/installer/gcapi/gcapi_omaha_experiment.cc ('k') | chrome/installer/gcapi/gcapi_reactivation_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698