Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: chrome/installer/gcapi/gcapi_last_run_test.cc

Issue 94013004: Add base:: to string16s in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try again Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/metro_driver_win.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 #include <string> 6 #include <string>
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/guid.h" 9 #include "base/guid.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 clients_path.c_str(), 48 clients_path.c_str(),
49 KEY_CREATE_SUB_KEY | KEY_SET_VALUE); 49 KEY_CREATE_SUB_KEY | KEY_SET_VALUE);
50 ASSERT_TRUE(client_key.Valid()); 50 ASSERT_TRUE(client_key.Valid());
51 client_key.WriteValue(L"pv", L"1.2.3.4"); 51 client_key.WriteValue(L"pv", L"1.2.3.4");
52 } 52 }
53 53
54 bool SetLastRunTime(int64 last_run_time) { 54 bool SetLastRunTime(int64 last_run_time) {
55 return SetLastRunTimeString(base::Int64ToString16(last_run_time)); 55 return SetLastRunTimeString(base::Int64ToString16(last_run_time));
56 } 56 }
57 57
58 bool SetLastRunTimeString(const string16& last_run_time_string) { 58 bool SetLastRunTimeString(const base::string16& last_run_time_string) {
59 const wchar_t* base_path = google_update::kRegPathClientState; 59 const wchar_t* base_path = google_update::kRegPathClientState;
60 std::wstring path(base_path); 60 std::wstring path(base_path);
61 path += L"\\"; 61 path += L"\\";
62 path += google_update::kChromeUpgradeCode; 62 path += google_update::kChromeUpgradeCode;
63 63
64 RegKey client_state(HKEY_CURRENT_USER, path.c_str(), KEY_SET_VALUE); 64 RegKey client_state(HKEY_CURRENT_USER, path.c_str(), KEY_SET_VALUE);
65 return (client_state.Valid() && 65 return (client_state.Valid() &&
66 client_state.WriteValue( 66 client_state.WriteValue(
67 google_update::kRegLastRunTimeField, 67 google_update::kRegLastRunTimeField,
68 last_run_time_string.c_str()) == ERROR_SUCCESS); 68 last_run_time_string.c_str()) == ERROR_SUCCESS);
(...skipping 22 matching lines...) Expand all
91 EXPECT_EQ(-1, days_since_last_run); 91 EXPECT_EQ(-1, days_since_last_run);
92 } 92 }
93 93
94 TEST_F(GCAPILastRunTest, OutOfRangeLastRun) { 94 TEST_F(GCAPILastRunTest, OutOfRangeLastRun) {
95 Time last_run = Time::NowFromSystemTime() - TimeDelta::FromDays(-42); 95 Time last_run = Time::NowFromSystemTime() - TimeDelta::FromDays(-42);
96 EXPECT_TRUE(SetLastRunTime(last_run.ToInternalValue())); 96 EXPECT_TRUE(SetLastRunTime(last_run.ToInternalValue()));
97 97
98 int days_since_last_run = GoogleChromeDaysSinceLastRun(); 98 int days_since_last_run = GoogleChromeDaysSinceLastRun();
99 EXPECT_EQ(-1, days_since_last_run); 99 EXPECT_EQ(-1, days_since_last_run);
100 } 100 }
OLDNEW
« no previous file with comments | « chrome/app/metro_driver_win.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698