Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/android/testshell/testshell_tab.cc

Issue 94013004: Add base:: to string16s in chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try again Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/android/testshell/testshell_tab.h ('k') | chrome/app/app_mode_loader_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/android/testshell/testshell_tab.h" 5 #include "chrome/android/testshell/testshell_tab.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/android/chrome_web_contents_delegate_android.h" 9 #include "chrome/browser/android/chrome_web_contents_delegate_android.h"
10 #include "chrome/browser/ui/android/window_android_helper.h" 10 #include "chrome/browser/ui/android/window_android_helper.h"
(...skipping 18 matching lines...) Expand all
29 } 29 }
30 30
31 TestShellTab::~TestShellTab() { 31 TestShellTab::~TestShellTab() {
32 } 32 }
33 33
34 void TestShellTab::Destroy(JNIEnv* env, jobject obj) { 34 void TestShellTab::Destroy(JNIEnv* env, jobject obj) {
35 delete this; 35 delete this;
36 } 36 }
37 37
38 void TestShellTab::OnReceivedHttpAuthRequest(jobject auth_handler, 38 void TestShellTab::OnReceivedHttpAuthRequest(jobject auth_handler,
39 const string16& host, 39 const base::string16& host,
40 const string16& realm) { 40 const base::string16& realm) {
41 NOTIMPLEMENTED(); 41 NOTIMPLEMENTED();
42 } 42 }
43 43
44 void TestShellTab::AddShortcutToBookmark( 44 void TestShellTab::AddShortcutToBookmark(
45 const GURL& url, const string16& title, const SkBitmap& skbitmap, 45 const GURL& url, const base::string16& title, const SkBitmap& skbitmap,
46 int r_value, int g_value, int b_value) { 46 int r_value, int g_value, int b_value) {
47 NOTIMPLEMENTED(); 47 NOTIMPLEMENTED();
48 } 48 }
49 49
50 void TestShellTab::EditBookmark(int64 node_id, 50 void TestShellTab::EditBookmark(int64 node_id,
51 const base::string16& node_title, 51 const base::string16& node_title,
52 bool is_folder, 52 bool is_folder,
53 bool is_partner_bookmark) { 53 bool is_partner_bookmark) {
54 NOTIMPLEMENTED(); 54 NOTIMPLEMENTED();
55 } 55 }
(...skipping 24 matching lines...) Expand all
80 std::string fixed_spec; 80 std::string fixed_spec;
81 if (fixed_url.is_valid()) 81 if (fixed_url.is_valid())
82 fixed_spec = fixed_url.spec(); 82 fixed_spec = fixed_url.spec();
83 83
84 return ConvertUTF8ToJavaString(env, fixed_spec); 84 return ConvertUTF8ToJavaString(env, fixed_spec);
85 } 85 }
86 86
87 static jlong Init(JNIEnv* env, jobject obj) { 87 static jlong Init(JNIEnv* env, jobject obj) {
88 return reinterpret_cast<intptr_t>(new TestShellTab(env, obj)); 88 return reinterpret_cast<intptr_t>(new TestShellTab(env, obj));
89 } 89 }
OLDNEW
« no previous file with comments | « chrome/android/testshell/testshell_tab.h ('k') | chrome/app/app_mode_loader_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698