Adding ability to bisect recipe to bisect into dependency repos.

scripts/slave/recipe_modules/auto_bisect/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """API for the bisect recipe module.
 
 This API is meant to enable the bisect recipe to bisect any chromium-supported
 platform for any test that can be run via buildbot, perf or otherwise.
 """
 
 from slave import recipe_api
 from . import bisector
 from . import perf_revision_state
 
 
 class AutoBisectApi(recipe_api.RecipeApi):
   """A module for bisect specific functions."""
 
   POLLING_INTERVAL = 60
   BUCKET = 'chrome-perf'
   RESULTS_GS_DIR = 'bisect-results'
   GS_RESULTS_URL = 'gs://%s/%s/' % (BUCKET, RESULTS_GS_DIR)
   SVN_REPO_URL = 'svn://svn.chromium.org/chrome-try/try-perf'
+  BOT_EMAIL = 'chrome_bot@chromium.org'

[qyearsley, 2015/03/10 23:20:48]

Note: Just looking at the names, I can't tell what all of these things are used
for. In this case, I think it may be a good idea to give individual
documentation for most of the constants.

My guesses about their purpose:

POLLING_INTERVAL: Interval in seconds for checking whether there are new test
results from a tester?
BUCKET, RESULTS_GS_DIR, GS_RESULTS_URL: Location of test results after tester
finishes?
SVN_REPO_URL: SVN repo for git try used when triggering tester?
BOT_EMAIL: ?

[RobertoCN, 2015/03/13 20:55:58]

Done.

 
   def __init__(self, *args, **kwargs):
     super(AutoBisectApi, self).__init__(*args, **kwargs)
     self.override_poll_interval = None
 
   def create_bisector(self, bisect_config):
     """Passes the api and the config dictionary to the Bisector constructor."""
     bisect_config_dict = bisect_config

[qyearsley, 2015/03/10 23:20:48]

Could you just call the argument bisect_config_dict and remove this line?

[RobertoCN, 2015/03/13 20:55:58]

Done.

     self.override_poll_interval = bisect_config_dict.get('poll_sleep', None)
     revision_class = self._get_revision_class(bisect_config_dict['test_type'])
     return bisector.Bisector(self, bisect_config_dict, revision_class)
 
   def _get_revision_class(self, test_type):
     """Gets the particular subclass of Revision needed for the test type."""
     if test_type == 'perf':
       return perf_revision_state.PerfRevisionState
     else: #pragma: no cover
       raise NotImplementedError()
 
   def gsutil_file_exists(self, path):
     """Returns True if a file exists at the given GS path."""
     try:
       self.m.gsutil(['ls', path])
     except self.m.step.StepFailure: #pragma: no cover
       return False
     return True