Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: components/audio_modem/audio_recorder_unittest.cc

Issue 940123004: Convert audio samples in Whispernet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/audio_modem/audio_recorder_unittest.cc
diff --git a/components/audio_modem/audio_recorder_unittest.cc b/components/audio_modem/audio_recorder_unittest.cc
index a05ad7f5f9087d37dafcc512a5a431faad62866b..51f1234f553d13612723137a32bb53e65b142982 100644
--- a/components/audio_modem/audio_recorder_unittest.cc
+++ b/components/audio_modem/audio_recorder_unittest.cc
@@ -193,17 +193,7 @@ class AudioRecorderTest : public testing::Test {
content::TestBrowserThreadBundle thread_bundle_;
};
-// TODO(rkc): These tests are broken on all platforms.
-// On Windows and Mac, we cannot use non-OS params. The tests need to be
-// rewritten to use the params provided to us by the audio manager
-// rather than setting our own params.
-// On Linux, there is a memory leak in the audio code during initialization.
-#define MAYBE_BasicRecordAndStop DISABLED_BasicRecordAndStop
-#define MAYBE_OutOfOrderRecordAndStopMultiple \
- DISABLED_OutOfOrderRecordAndStopMultiple
-#define MAYBE_RecordingEndToEnd DISABLED_RecordingEndToEnd
-
-TEST_F(AudioRecorderTest, MAYBE_BasicRecordAndStop) {
+TEST_F(AudioRecorderTest, BasicRecordAndStop) {
Charlie 2015/02/20 00:58:21 Cool! I had a bug open about this.
rkc 2015/02/20 18:53:07 I added a few more changes to make sure that these
CreateSimpleRecorder();
recorder_->Record();
@@ -224,7 +214,7 @@ TEST_F(AudioRecorderTest, MAYBE_BasicRecordAndStop) {
DeleteRecorder();
}
-TEST_F(AudioRecorderTest, MAYBE_OutOfOrderRecordAndStopMultiple) {
+TEST_F(AudioRecorderTest, OutOfOrderRecordAndStopMultiple) {
CreateSimpleRecorder();
recorder_->Stop();
@@ -243,7 +233,7 @@ TEST_F(AudioRecorderTest, MAYBE_OutOfOrderRecordAndStopMultiple) {
DeleteRecorder();
}
-TEST_F(AudioRecorderTest, MAYBE_RecordingEndToEnd) {
+TEST_F(AudioRecorderTest, RecordingEndToEnd) {
const int kNumSamples = 48000 * 3;
CreateRecorder(
kDefaultChannels, kDefaultSampleRate, kDefaultBitsPerSample, kNumSamples);

Powered by Google App Engine
This is Rietveld 408576698