Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 940123003: [Telemetry] Add indentation to json_output & chart_json_output. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
eakuefner, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add indentation to json_output & chart_json_output. Rationale: ocassionally I find it useful to look at json_output to debug. Indenting the file make it a lot more readable. The downside is this increases the file size, but it shouldn't matter for small files like these. An example Results.json with ~2000 values tested on local machine: Without indent: 472K With indentation: 692K Committed: https://crrev.com/cc27e302c16fcf0d0108e077567cd2d748d6740d Cr-Commit-Position: refs/heads/master@{#317175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/results/chart_json_output_formatter.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
nednguyen
5 years, 10 months ago (2015-02-19 22:44:22 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-19 22:45:12 UTC) #3
eakuefner
My approach for when I need to read JSON output from Telemetry has usually been ...
5 years, 10 months ago (2015-02-19 22:48:11 UTC) #4
eakuefner
On 2015/02/19 at 22:48:11, eakuefner wrote: > My approach for when I need to read ...
5 years, 10 months ago (2015-02-19 22:49:05 UTC) #5
eakuefner
On 2015/02/19 at 22:49:05, eakuefner wrote: > On 2015/02/19 at 22:48:11, eakuefner wrote: > > ...
5 years, 10 months ago (2015-02-19 22:53:19 UTC) #6
nednguyen
On 2015/02/19 22:53:19, eakuefner wrote: > On 2015/02/19 at 22:49:05, eakuefner wrote: > > On ...
5 years, 10 months ago (2015-02-19 22:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940123003/1
5 years, 10 months ago (2015-02-19 22:54:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 23:51:23 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 23:52:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc27e302c16fcf0d0108e077567cd2d748d6740d
Cr-Commit-Position: refs/heads/master@{#317175}

Powered by Google App Engine
This is Rietveld 408576698