Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940033003: Cleanup iOS upstreamed code (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
droger, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom_distiller
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup iOS upstreamed code - remove unused consumer code wrapping base/ios/ios_util.h - remove superfluous #include of base/ios/ios_util.h BUG=429756 TBR=thakis Committed: https://crrev.com/cdc03121d7c798a87c4c90fd16981065ed06c5db Cr-Commit-Position: refs/heads/master@{#317054}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -71 lines) Patch
M base/ios/device_util.mm View 1 chunk +0 lines, -1 line 0 comments Download
M base/ios/device_util_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_ios_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
D ios/consumer/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/consumer/README.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D ios/consumer/base/util.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/ios.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D ios/ios_base.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
M ios/ios_tests_unit.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ios/public/consumer/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/public/consumer/base/util.h View 1 chunk +0 lines, -15 lines 0 comments Download
M skia/ext/skia_utils_ios_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
droger: please take a look thakis: (TBR-ed) OWNERS for - base/ios - skia/ext/skia_utils
5 years, 10 months ago (2015-02-19 15:00:55 UTC) #2
droger
lgtm
5 years, 10 months ago (2015-02-19 15:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940033003/20001
5 years, 10 months ago (2015-02-19 15:08:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 15:38:44 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 15:39:23 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cdc03121d7c798a87c4c90fd16981065ed06c5db
Cr-Commit-Position: refs/heads/master@{#317054}

Powered by Google App Engine
This is Rietveld 408576698