Remove LSan options/suppressions from test_env.py.

Remove LSan options/suppressions from test_env.py.

Those are now compiled into the executable.
Also remove tools/lsan/ which used to house the suppressions file.

BUG=302040
R=kjellander@chromium.org

Committed: https://crrev.com/09fef383665c6d75776bb0b649b29685b38ce617
Cr-Commit-Position: refs/heads/master@{#318035}

[kjellander_chromium, 2015-02-22 19:06:56]

lgtm

[earthdok, 2015-02-25 12:57:42]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-02-25 12:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/940033002/1

[commit-bot: I haz the power, 2015-02-25 13:32:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-25 13:32:30]

Patchset 1 (id:??) landed as
https://crrev.com/09fef383665c6d75776bb0b649b29685b38ce617
Cr-Commit-Position: refs/heads/master@{#318035}

[phoglund_chromium, 2015-02-25 14:29:06]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/956603004/ by phoglund@chromium.org.

The reason for reverting is: Breaks Linux ASAN:

https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...

The error is:

MappingError: Input file
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
doesn't exist
.

[kjellander_chromium, 2015-02-25 20:17:05]

On 2015/02/25 14:29:06, phoglund wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/956603004/ by mailto:phoglund@chromium.org.
> 
> The reason for reverting is: Breaks Linux ASAN:
> 
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> 
> The error is:
> 
> MappingError: Input file
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> doesn't exist
> .

I guess it might be a good idea to add a trybot that runs asan+lsan so things
like this would get caught in presubmit?

[earthdok, 2015-02-26 14:08:57]

On 2015/02/25 20:17:05, kjellander wrote:
> On 2015/02/25 14:29:06, phoglund wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/956603004/ by mailto:phoglund@chromium.org.
> > 
> > The reason for reverting is: Breaks Linux ASAN:
> > 
> >
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> > 
> > The error is:
> > 
> > MappingError: Input file
> >
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> > doesn't exist
> > .
> 
> I guess it might be a good idea to add a trybot that runs asan+lsan so things
> like this would get caught in presubmit?

Our ASan trybots have been running LSan for over a year. The problem is that the
analyze step decided this is not worth testing:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

Unfortunately, I don't think you can manually specify a test target anymore,
either.

[kjellander_chromium, 2015-02-26 14:10:55]

On 2015/02/26 14:08:57, earthdok wrote:
> On 2015/02/25 20:17:05, kjellander wrote:
> > On 2015/02/25 14:29:06, phoglund wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/956603004/ by
mailto:phoglund@chromium.org.
> > > 
> > > The reason for reverting is: Breaks Linux ASAN:
> > > 
> > >
> >
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> > > 
> > > The error is:
> > > 
> > > MappingError: Input file
> > >
> >
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> > > doesn't exist
> > > .
> > 
> > I guess it might be a good idea to add a trybot that runs asan+lsan so
things
> > like this would get caught in presubmit?
> 
> Our ASan trybots have been running LSan for over a year. The problem is that
the
> analyze step decided this is not worth testing:
> 
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> 
> Unfortunately, I don't think you can manually specify a test target anymore,
> either.

Ah, sorry about that. I guess it will be hard to have intelligent detection for
infrastructure related changes like this. Not much to do then.

[earthdok, 2015-02-26 14:11:48]

On 2015/02/26 14:10:55, kjellander wrote:
> On 2015/02/26 14:08:57, earthdok wrote:
> > On 2015/02/25 20:17:05, kjellander wrote:
> > > On 2015/02/25 14:29:06, phoglund wrote:
> > > > A revert of this CL (patchset #1 id:1) has been created in
> > > > https://codereview.chromium.org/956603004/ by
> mailto:phoglund@chromium.org.
> > > > 
> > > > The reason for reverting is: Breaks Linux ASAN:
> > > > 
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> > > > 
> > > > The error is:
> > > > 
> > > > MappingError: Input file
> > > >
> > >
> >
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> > > > doesn't exist
> > > > .
> > > 
> > > I guess it might be a good idea to add a trybot that runs asan+lsan so
> things
> > > like this would get caught in presubmit?
> > 
> > Our ASan trybots have been running LSan for over a year. The problem is that
> the
> > analyze step decided this is not worth testing:
> > 
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> > 
> > Unfortunately, I don't think you can manually specify a test target anymore,
> > either.
> 
> Ah, sorry about that. I guess it will be hard to have intelligent detection
for
> infrastructure related changes like this. Not much to do then.

I think it's still worth filing a bug for. Do you know who is responsible for
analyze.py?

[kjellander_chromium, 2015-02-26 14:17:13]

On 2015/02/26 14:11:48, earthdok wrote:
> On 2015/02/26 14:10:55, kjellander wrote:
> > On 2015/02/26 14:08:57, earthdok wrote:
> > > On 2015/02/25 20:17:05, kjellander wrote:
> > > > On 2015/02/25 14:29:06, phoglund wrote:
> > > > > A revert of this CL (patchset #1 id:1) has been created in
> > > > > https://codereview.chromium.org/956603004/ by
> > mailto:phoglund@chromium.org.
> > > > > 
> > > > > The reason for reverting is: Breaks Linux ASAN:
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> > > > > 
> > > > > The error is:
> > > > > 
> > > > > MappingError: Input file
> > > > >
> > > >
> > >
> >
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> > > > > doesn't exist
> > > > > .
> > > > 
> > > > I guess it might be a good idea to add a trybot that runs asan+lsan so
> > things
> > > > like this would get caught in presubmit?
> > > 
> > > Our ASan trybots have been running LSan for over a year. The problem is
that
> > the
> > > analyze step decided this is not worth testing:
> > > 
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> > > 
> > > Unfortunately, I don't think you can manually specify a test target
anymore,
> > > either.
> > 
> > Ah, sorry about that. I guess it will be hard to have intelligent detection
> for
> > infrastructure related changes like this. Not much to do then.
> 
> I think it's still worth filing a bug for. Do you know who is responsible for
> analyze.py?

mark@chromium.org and  sky@chromium.org are the only authors (sky did most CLs)
for tools/gyp/pylib/gyp/generators/analyzer.py

[earthdok, 2015-02-26 15:28:57]

On 2015/02/26 14:17:13, kjellander wrote:
> On 2015/02/26 14:11:48, earthdok wrote:
> > On 2015/02/26 14:10:55, kjellander wrote:
> > > On 2015/02/26 14:08:57, earthdok wrote:
> > > > On 2015/02/25 20:17:05, kjellander wrote:
> > > > > On 2015/02/25 14:29:06, phoglund wrote:
> > > > > > A revert of this CL (patchset #1 id:1) has been created in
> > > > > > https://codereview.chromium.org/956603004/ by
> > > mailto:phoglund@chromium.org.
> > > > > > 
> > > > > > The reason for reverting is: Breaks Linux ASAN:
> > > > > > 
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20B...
> > > > > > 
> > > > > > The error is:
> > > > > > 
> > > > > > MappingError: Input file
> > > > > >
> > > > >
> > > >
> > >
> >
>
/mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt
> > > > > > doesn't exist
> > > > > > .
> > > > > 
> > > > > I guess it might be a good idea to add a trybot that runs asan+lsan so
> > > things
> > > > > like this would get caught in presubmit?
> > > > 
> > > > Our ASan trybots have been running LSan for over a year. The problem is
> that
> > > the
> > > > analyze step decided this is not worth testing:
> > > > 
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> > > > 
> > > > Unfortunately, I don't think you can manually specify a test target
> anymore,
> > > > either.
> > > 
> > > Ah, sorry about that. I guess it will be hard to have intelligent
detection
> > for
> > > infrastructure related changes like this. Not much to do then.
> > 
> > I think it's still worth filing a bug for. Do you know who is responsible
for
> > analyze.py?
> 
> mailto:mark@chromium.org and  mailto:sky@chromium.org are the only authors
(sky did most CLs)
> for tools/gyp/pylib/gyp/generators/analyzer.py

This inspired me to file http://crbug.com/462228
Of course, the breakage here was due to base.isolate and not due to test_env.py.
However:
a) it would've helped in this particular case if trybots were triggered due to
the test_env.py change;
b) solving this problem for test_env.py is a much easier task than looking for
broken isolates (literally any change could break some .isolate somewhere);
c) isolation is easily testable locally whereas test_env.py is not.