Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 94003004: [SyncFS] Add verbose logging to SyncEngineInitializer (Closed)

Created:
7 years ago by tzik
Modified:
7 years ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki
Visibility:
Public.

Description

[SyncFS] Add verbose logging to SyncEngineInitializer BUG=240165 R=kinuko@chromium.org, nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241126

Patch Set 1 #

Patch Set 2 : buildfix #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : +list_changes_task logging #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 1 2 3 4 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 2 11 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
PTL
7 years ago (2013-12-16 04:41:03 UTC) #1
nhiroki
lgtm https://codereview.chromium.org/94003004/diff/20001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc (right): https://codereview.chromium.org/94003004/diff/20001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc#newcode355 chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:355: "[Initialize] Got invalid initail app-root list."); nit: initail ...
7 years ago (2013-12-16 04:52:59 UTC) #2
tzik
https://codereview.chromium.org/94003004/diff/20001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc (right): https://codereview.chromium.org/94003004/diff/20001/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc#newcode355 chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:355: "[Initialize] Got invalid initail app-root list."); On 2013/12/16 04:52:59, ...
7 years ago (2013-12-16 05:03:23 UTC) #3
kinuko
lgtm
7 years ago (2013-12-16 05:08:29 UTC) #4
tzik
7 years ago (2013-12-17 03:05:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #6 manually as r241126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698