Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 939953002: Make generator constructors configurable (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make generator constructors configurable R=mstarzinger@chromium.org BUG=v8:3902 LOG=Y Committed: https://crrev.com/4c082b570da7f53f8f650764b513705f08c62093 Cr-Commit-Position: refs/heads/master@{#26744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/generator.js View 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/es6/regress/regress-3902.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rossberg
5 years, 10 months ago (2015-02-19 10:06:06 UTC) #1
Michael Starzinger
LGTM. Please prefix the BUG-line in the description with "v8:" so that it's properly linked.
5 years, 10 months ago (2015-02-19 10:19:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939953002/1
5 years, 10 months ago (2015-02-19 10:52:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/680)
5 years, 10 months ago (2015-02-19 10:55:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939953002/1
5 years, 10 months ago (2015-02-19 11:27:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 11:30:29 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 11:30:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c082b570da7f53f8f650764b513705f08c62093
Cr-Commit-Position: refs/heads/master@{#26744}

Powered by Google App Engine
This is Rietveld 408576698