Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939933002: Remove receiver as parameter to Get/Has Element in the accessors. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove receiver as parameter to Get/Has Element in the accessors. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/4a030e849c5b3ae3919d45a746037f4322c235a3 Cr-Commit-Position: refs/heads/master@{#26735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -83 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.h View 3 chunks +3 lines, -9 lines 0 comments Download
M src/elements.cc View 15 chunks +19 lines, -59 lines 0 comments Download
M src/objects.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M src/runtime/runtime-array.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-19 06:34:26 UTC) #2
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-19 06:37:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939933002/1
5 years, 10 months ago (2015-02-19 06:38:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/8)
5 years, 10 months ago (2015-02-19 07:02:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939933002/1
5 years, 10 months ago (2015-02-19 07:20:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1552)
5 years, 10 months ago (2015-02-19 08:05:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939933002/1
5 years, 10 months ago (2015-02-19 08:11:20 UTC) #13
Toon Verwaest
Committed patchset #1 (id:1) manually as 4a030e849c5b3ae3919d45a746037f4322c235a3 (presubmit successful).
5 years, 10 months ago (2015-02-19 08:13:56 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a030e849c5b3ae3919d45a746037f4322c235a3 Cr-Commit-Position: refs/heads/master@{#26735}
5 years, 10 months ago (2015-02-19 08:13:58 UTC) #16
arv (Not doing code reviews)
Could you elaborate why the receiver is no longer needed?
5 years, 10 months ago (2015-02-19 15:52:29 UTC) #17
Toon Verwaest
5 years, 10 months ago (2015-02-19 16:10:00 UTC) #18
Message was sent while issue was closed. 
It has never been required, it was just passed in.

Powered by Google App Engine
This is Rietveld 408576698