Issue 939923003: Revert of [x64] Generate test reg,reg instead of cmp reg,0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939923003: Revert of [x64] Generate test reg,reg instead of cmp reg,0. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer

Modified:
5 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [x64] Generate test reg,reg instead of cmp reg,0. (patchset #2 id:20001 of https://codereview.chromium.org/916543004/) Reason for revert: Tanks some benchmarks (for no obvious reason) Original issue's description: > [x64] Generate test reg,reg instead of cmp reg,0. > > The instruction sequence is shorter and saves decoding bandwidth. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/a7fb5ed400701b22c455d0ad410bc98b211e5730 > Cr-Commit-Position: refs/heads/master@{#26734} TBR=svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/28483ffeb3ce527275a0bf745caac51ae00ea2f8 Cr-Commit-Position: refs/heads/master@{#26742}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -23 lines)			Patch
	M	src/compiler/x64/code-generator-x64.cc	View		2 chunks	+2 lines, -23 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Created Revert of [x64] Generate test reg,reg instead of cmp reg,0.

5 years, 10 months ago (2015-02-19 10:37:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939923003/1

5 years, 10 months ago (2015-02-19 10:38:19 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 10:38:39 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/28483ffeb3ce527275a0bf745caac51ae00ea2f8
Cr-Commit-Position: refs/heads/master@{#26742}