Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
939883002:
Service Worker: Expand path restriction error message to instruct how to fix (Closed)
|
Created:
5 years, 10 months ago by falken Modified:
5 years, 10 months ago Reviewers:
kinuko CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionService Worker: Expand path restriction error message to instruct how to fix
It may not be readily apparent how to the fix the error otherwise.
BUG=457097
Committed: https://crrev.com/4711998ecc3ff3bcfcffeba9ab86e5062666c540
Cr-Commit-Position: refs/heads/master@{#317010}
Patch Set 1 #Patch Set 2 : format #
Total comments: 1
Patch Set 3 : http header #Messages
Total messages: 21 (9 generated)
falken@chromium.org changed reviewers: + kinuko@chromium.org
lgtm https://codereview.chromium.org/939883002/diff/20001/content/browser/service_... File content/browser/service_worker/service_worker_utils.cc (right): https://codereview.chromium.org/939883002/diff/20001/content/browser/service_... content/browser/service_worker/service_worker_utils.cc:82: "script, or use Service-Worker-Allowed to allow the scope."); nit: Service-Worker-Allowed -> 'Service-Worker-Allowed header' (or HTTP header) might be more informative
New patchsets have been uploaded after l-g-t-m from kinuko@chromium.org
thanks, done
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939883002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939883002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939883002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939883002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4711998ecc3ff3bcfcffeba9ab86e5062666c540 Cr-Commit-Position: refs/heads/master@{#317010} |
