Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 939853003: Revert of Reland #4: Ensure WebView notifies desktop automation on creation, (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #4: Ensure WebView notifies desktop automation on creation, (patchset #1 id:1 of https://codereview.chromium.org/940763002/) Reason for revert: Still flakes on bots. Original issue's description: > Reland #4: Ensure WebView notifies desktop automation on creation, destruction, and change > > Previous attempts: > https://codereview.chromium.org/880063002 > https://codereview.chromium.org/895623003/ > https://codereview.chromium.org/890013006/ > https://codereview.chromium.org/907973004/ > > This latest attempt removes the logic that reloads ChromeVox at the beginning of a test. > > Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout. > > With the above change, this no longer occurs and hopefully fixes the flakeyness. > > Change is located in chromevox_e2e_test_base.js. > > TBR=dmazzoni@chromium.org > > Committed: https://crrev.com/47cb3b3798d325f3083565a05a2dcdaee117c296 > Cr-Commit-Position: refs/heads/master@{#316950} TBR=dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f8476d3181eef9319e5f53049b254a6dc476f49c Cr-Commit-Position: refs/heads/master@{#316971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -165 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 5 chunks +52 lines, -33 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 4 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 3 chunks +14 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +5 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/base/extension_js_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 7 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Tseng
Created Revert of Reland #4: Ensure WebView notifies desktop automation on creation,
5 years, 10 months ago (2015-02-19 02:18:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939853003/1
5 years, 10 months ago (2015-02-19 02:19:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 02:20:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8476d3181eef9319e5f53049b254a6dc476f49c Cr-Commit-Position: refs/heads/master@{#316971}
5 years, 10 months ago (2015-02-19 02:20:46 UTC) #4
David Tseng
5 years, 10 months ago (2015-02-19 02:37:01 UTC) #5
Message was sent while issue was closed.
Dominic or Peter:
Do you guys know if the bots have a shorter timeout?
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
shows around 6 seconds per test. That's not enough time for these tests.
Locally, the timeout is 30 seconds.

Thanks.

On Wed, Feb 18, 2015 at 6:20 PM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/f8476d3181eef9319e5f53049b254a6dc476f49c
> Cr-Commit-Position: refs/heads/master@{#316971}
>
> https://codereview.chromium.org/939853003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698