Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 939803002: [Extensions] Update renderers when all-urls is granted (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update renderers when all-urls is granted Committed: https://crrev.com/1f8770329f2bd922cb13783d5daa4ed42ae2a0f2 Cr-Commit-Position: refs/heads/master@{#317183}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -6 lines) Patch
M chrome/browser/extensions/active_script_controller.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/active_script_controller_browsertest.cc View 1 2 chunks +54 lines, -0 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 3 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
5 years, 10 months ago (2015-02-18 23:57:28 UTC) #2
not at google - send to devlin
Before I review, I think I filed a bug about this.
5 years, 10 months ago (2015-02-19 18:11:14 UTC) #3
not at google - send to devlin
lgtm, but is there a test you can augment to support this?
5 years, 10 months ago (2015-02-19 18:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939803002/20001
5 years, 10 months ago (2015-02-19 23:33:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 00:12:55 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 00:13:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f8770329f2bd922cb13783d5daa4ed42ae2a0f2
Cr-Commit-Position: refs/heads/master@{#317183}

Powered by Google App Engine
This is Rietveld 408576698