Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 939763003: Tweak "debug on start" description in chrome://serviceworker-internals (Closed)

Created:
5 years, 10 months ago by falken
Modified:
5 years, 10 months ago
Reviewers:
horo
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak "debug on start" description in chrome://serviceworker-internals Some users of the checkbox reported not expecting the SW to pause on startup. BUG=455708 Committed: https://crrev.com/3d1009fc28dbd25f79bf5a2418197a97003d49a3 Cr-Commit-Position: refs/heads/master@{#317009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/resources/service_worker/serviceworker_internals.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
falken
5 years, 10 months ago (2015-02-19 02:42:25 UTC) #2
horo
lgtm
5 years, 10 months ago (2015-02-19 03:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939763003/1
5 years, 10 months ago (2015-02-19 03:19:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/27962)
5 years, 10 months ago (2015-02-19 05:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939763003/1
5 years, 10 months ago (2015-02-19 05:12:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/34263)
5 years, 10 months ago (2015-02-19 06:21:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939763003/1
5 years, 10 months ago (2015-02-19 06:50:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/4)
5 years, 10 months ago (2015-02-19 07:05:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939763003/1
5 years, 10 months ago (2015-02-19 07:20:54 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 08:30:58 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 08:31:28 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1009fc28dbd25f79bf5a2418197a97003d49a3
Cr-Commit-Position: refs/heads/master@{#317009}

Powered by Google App Engine
This is Rietveld 408576698