device/bluetooth: Implement Unregister() of BlueotoothAudioSinkChromeOS and disconnection-related c…

device/bluetooth/bluetooth_audio_sink.h

Index: device/bluetooth/bluetooth_audio_sink.h
diff --git a/device/bluetooth/bluetooth_audio_sink.h b/device/bluetooth/bluetooth_audio_sink.h
index 331ef0d83d1dac7653b745d899a694339ae7fce2..df5f1898705d9195ee57393055657c341aa86f5c 100644
--- a/device/bluetooth/bluetooth_audio_sink.h
+++ b/device/bluetooth/bluetooth_audio_sink.h
@@ -40,8 +40,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAudioSink
   // Possible types of error raised by Audio Sink object.
   enum ErrorCode {
     ERROR_UNSUPPORTED_PLATFORM,  // A2DP sink not supported on current platform.
-    ERROR_INVALID_ADAPTER,       // BluetoothAdapter not presented/powered.
-    ERROR_NOT_REGISTERED,        // BluetoothAudioSink not registered.
+    ERROR_INVALID_ADAPTER,  // BluetoothAdapter not presented/powered.
+    ERROR_NOT_REGISTERED,  // BluetoothAudioSink not registered.
   };
 
   // Options to configure an A2DP audio sink.
@@ -84,8 +84,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAudioSink
   // Unregisters the audio sink. An audio sink will unregister itself
   // automatically in its destructor, but calling Unregister is recommended,
   // since user applications can be notified of an error returned by the call.

[Ben Chan, 2015/02/19 00:21:45]

is this comment still valid?

"since user applications can be notified of an error returned by the call" 

[Miao, 2015/02/23 21:04:24]

Recovered the error callback, so the the comment stays valid.

-  virtual void Unregister(const base::Closure& callback,
-                          const ErrorCallback& error_callback) = 0;
+  virtual void Unregister(const base::Closure& callback) = 0;

[armansito, 2015/02/19 00:37:46]

Why did you remove the error callback? Also, without the error callback, the
comment above doesn't make much sense, since you can't return an error.

[Miao, 2015/02/23 21:04:24]

Done.

 
   // Adds and removes an observer for events on the BluetoothAudioSink object.
   // If monitoring multiple audio sinks, check the |audio_sink| parameter of