Issue 939753003: Fix buggy usage of global variables in the build system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939753003: Fix buggy usage of global variables in the build system (Closed)

Created:
5 years, 10 months ago by blundell

Modified:
5 years, 10 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Nick Bray (chromium)

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix buggy usage of global variables in the build system //build/module_args/mojo.gni defined variables whose values were then modified in //mojo/public/mojo.gni. This is not a legit practice in GN. GN doesn't complain as long as the variable isn't actually set to a different value, but barfs once the variable's value is actually changed in the second file (which is why this took a little while to shake itself out). The remedy is to use different variable names in the two files. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c2261135ee590acd78d6903ae09a5c9bdec4f523

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	build/module_args/mojo.gni	View		1 chunk	+6 lines, -6 lines	0 comments	Download
	M	mojo/public/mojo.gni	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

blundell

Nick, I'm just waiting to land https://codereview.chromium.org/944843002/ in Chromium and then I'll land this.

5 years, 10 months ago (2015-02-20 13:03:18 UTC) #4

blundell

5 years, 10 months ago (2015-02-20 20:27:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2261135ee590acd78d6903ae09a5c9bdec4f523 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages