sandbox: Change directory names in ProcUtil test to support Android

sandbox: Change directory names in ProcUtil test to support Android

The ProcUtil tests HasOpenDirectory HasOpenDirectoryWithFD use
/dev to test HasOpenDirectory. /dev fails to open on Android
due to SELinux. This change picks /proc/self instead, which
will work on all linux platforms.

BUG=459360
TEST=sandbox_linux_unittests

Committed: https://crrev.com/5a50fdd84f42a4df08cced9d792985336b5335a4
Cr-Commit-Position: refs/heads/master@{#317366}

[leecam, 2015-02-18 21:41:53]

leecam@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2015-02-19 00:47:21]

Thanks Lee, lgtm!

https://chromiumcodereview.appspot.com/939723003/diff/1/sandbox/linux/service...
File sandbox/linux/services/proc_util_unittest.cc (right):

https://chromiumcodereview.appspot.com/939723003/diff/1/sandbox/linux/service...
sandbox/linux/services/proc_util_unittest.cc:51: // Have a "/proc/self" file
descriptor around.
It's a little confusing to use /proc/self/ given that there is also a |proc_fd|.

How about /sys/ or /proc/sys/, would that work?

[leecam, 2015-02-20 00:27:43]

https://codereview.chromium.org/939723003/diff/1/sandbox/linux/services/proc_...
File sandbox/linux/services/proc_util_unittest.cc (right):

https://codereview.chromium.org/939723003/diff/1/sandbox/linux/services/proc_...
sandbox/linux/services/proc_util_unittest.cc:51: // Have a "/proc/self" file
descriptor around.
On 2015/02/19 00:47:21, jln wrote:
> It's a little confusing to use /proc/self/ given that there is also a
|proc_fd|.
> 
> How about /sys/ or /proc/sys/, would that work?

Yeah at the moment but nnk is working to lock down /proc further so you can only
get to /proc/X where X is a pid in the same container or 'self'. So I picked
/proc/self as I think it would be safest thing for the future...

[jln (very slow on Chromium), 2015-02-20 01:14:14]

https://codereview.chromium.org/939723003/diff/1/sandbox/linux/services/proc_...
File sandbox/linux/services/proc_util_unittest.cc (right):

https://codereview.chromium.org/939723003/diff/1/sandbox/linux/services/proc_...
sandbox/linux/services/proc_util_unittest.cc:51: // Have a "/proc/self" file
descriptor around.
On 2015/02/20 00:27:43, leecam wrote:
> On 2015/02/19 00:47:21, jln wrote:
> > It's a little confusing to use /proc/self/ given that there is also a
> |proc_fd|.
> > 
> > How about /sys/ or /proc/sys/, would that work?
> 
> Yeah at the moment but nnk is working to lock down /proc further so you can
only
> get to /proc/X where X is a pid in the same container or 'self'. So I picked
> /proc/self as I think it would be safest thing for the future... 

Maybe rename the variable from "proc_self_fd" to "open_directory_fd" and simply
say "Have a directory file descriptor around" in the comment for the function?

[leecam, 2015-02-20 17:42:24]

New patchsets have been uploaded after l-g-t-m from jln@chromium.org

[leecam, 2015-02-20 17:43:37]

The CQ bit was checked by leecam@chromium.org

[commit-bot: I haz the power, 2015-02-20 17:44:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939723003/20001

[commit-bot: I haz the power, 2015-02-20 18:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:42:46]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[leecam, 2015-02-20 19:14:49]

The CQ bit was checked by leecam@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:16:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939723003/20001

[commit-bot: I haz the power, 2015-02-20 19:23:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 19:24:01]

Patchset 2 (id:??) landed as
https://crrev.com/5a50fdd84f42a4df08cced9d792985336b5335a4
Cr-Commit-Position: refs/heads/master@{#317366}