Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: components/search_engines/template_url.h

Issue 939713003: Enabled the "search web for image" context menu item when "Yandex" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url.h
diff --git a/components/search_engines/template_url.h b/components/search_engines/template_url.h
index a5997934c0bf6e94bbc54d812ad27069f455d3c9..e589b7495d3793e722badcf6c73eb90b4a8201ed 100644
--- a/components/search_engines/template_url.h
+++ b/components/search_engines/template_url.h
@@ -181,6 +181,9 @@ class TemplateURLRef {
// search-by-image frontend.
std::string image_thumbnail_content;
+ // The format of the raw content of an image thumbnail, e.g. "jpeg".
Peter Kasting 2015/02/18 21:55:51 Nit: May want to say something about this needing
Vitaly Baranov 2015/02/19 17:31:20 The Yandex.Images service expects a valid image Co
+ std::string image_thumbnail_format;
+
// When searching for an image, the URL of the original image. Callers
// should leave this empty for images specified via data: URLs.
GURL image_url;
@@ -346,8 +349,12 @@ class TemplateURLRef {
// The list of elements to replace.
typedef std::vector<struct Replacement> Replacements;
- // Type to store <key, value> pairs for POST URLs.
- typedef std::pair<std::string, std::string> PostParam;
+ // Type to store parameter for POST URLs.
Peter Kasting 2015/02/18 21:55:51 Nit: How about: "Stores a single parameter for a P
Vitaly Baranov 2015/02/19 17:31:20 Done.
+ struct PostParam {
Peter Kasting 2015/02/18 21:55:52 Nit: Move this struct above the two typedefs and p
Vitaly Baranov 2015/02/19 17:31:20 Done.
+ std::string value_name;
Peter Kasting 2015/02/18 21:55:51 Nit: Why |value_name| instead of just |name|?
Vitaly Baranov 2015/02/19 17:31:20 Renamed. And that was because that name is used in
+ std::string value;
+ std::string content_type;
+ };
typedef std::vector<PostParam> PostParams;
// TemplateURLRef internally caches values to make replacement quick. This

Powered by Google App Engine
This is Rietveld 408576698