Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

Issue 939653002: Files.app: Add MetadataItem class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove empty line. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
index 1efae04d9e4d73384a699f05bb6fced3584577bf..5f0b8a2f408cac4a81ee211b813270bbd2968859 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
@@ -54,11 +54,12 @@ MetadataCacheItem.prototype.startRequests = function(requestId, names) {
/**
* Feeds the result of startRequests.
* @param {number} requestId Request ID passed when calling startRequests.
- * @param {!Object} object Map of property name and value.
+ * @param {!MetadataItem} typedObject Map of property name and value.
* @return {boolean} Whether at least one property is updated or not.
*/
-MetadataCacheItem.prototype.storeProperties = function(requestId, object) {
+MetadataCacheItem.prototype.storeProperties = function(requestId, typedObject) {
var changed = false;
+ var object = /** @type {!Object} */(typedObject);
for (var name in object) {
if (!this.properties_[name])
this.properties_[name] = new MetadataCacheItemProperty();
@@ -93,16 +94,16 @@ MetadataCacheItem.prototype.invalidate = function(requestId) {
* Obtains property for entries and names.
* Note that it returns invalidated properties also.
* @param {!Array<string>} names
- * @return {!Object}
+ * @return {!MetadataItem}
*/
MetadataCacheItem.prototype.get = function(names) {
- var result = {};
+ var result = /** @type {!Object} */(new MetadataItem());
for (var i = 0; i < names.length; i++) {
var name = names[i];
if (this.properties_[name])
result[name] = this.properties_[name].value;
}
- return result;
+ return /** @type {!MetadataItem} */(result);
};
/**

Powered by Google App Engine
This is Rietveld 408576698