Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js

Issue 939653002: Files.app: Add MetadataItem class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove empty line. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js
index f1700a2c135a720bac01d1f266734bb78265c955..01c8519e871a196d65773d45c2a71ac60814e7ed 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js
@@ -3,17 +3,11 @@
// found in the LICENSE file.
/**
- * @typedef {{modificationTime:Date, size:number, contentMimeType:string,
- * present:boolean, availableOffline: boolean}}
- */
-var FileSystemMetadataProperties;
-
-/**
* Metadata provider for FileEntry#getMetadata.
*
* @param {!MetadataProviderCache} cache
* @constructor
- * @extends {NewMetadataProvider<!FileSystemMetadataProperties>}
+ * @extends {NewMetadataProvider}
* @struct
*/
function FileSystemMetadataProvider(cache) {
@@ -25,7 +19,7 @@ function FileSystemMetadataProvider(cache) {
* @const {!Array<string>}
*/
FileSystemMetadataProvider.PROPERTY_NAMES = [
- 'modificationTime', 'size', 'present', 'availableOffline', 'contentMimeType'
+ 'modificationTime', 'size', 'present', 'availableOffline', 'contentMimeType'
];
FileSystemMetadataProvider.prototype.__proto__ = NewMetadataProvider.prototype;
@@ -48,19 +42,16 @@ FileSystemMetadataProvider.prototype.getImpl = function(requests) {
}
})
]).then(function(results) {
- var result = {
- modificationTime: results[0].modificationTime,
- size: request.entry.isDirectory ? -1 : results[0].size,
- present: true,
- availableOffline: true,
- };
-
+ var item = new MetadataItem();
+ item.modificationTime = results[0].modificationTime;
+ item.size = request.entry.isDirectory ? -1 : results[0].size;
+ item.present = true;
+ item.availableOffline = true;
if (results[1] !== null)
- result['contentMimeType'] = results[1];
-
- return result;
+ item.contentMimeType = results[1];
+ return item;
}, function() {
- return {};
+ return new MetadataItem();
});
}));
};

Powered by Google App Engine
This is Rietveld 408576698