Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: base/file_util_unittest.cc

Issue 93963003: Fix a test failure as GetFileSize() will not set the size if it fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 3594749b4b1fe7c8ff6f73c4d79c9fba641d028d..06843fae4acf7581b09553deb51368001d27172b 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -2360,8 +2360,7 @@ TEST_F(FileUtilTest, NonExistentContentUriTest) {
EXPECT_FALSE(base::PathExists(path));
// Size should be smaller than 0.
int64 size;
- file_util::GetFileSize(path, &size);
- EXPECT_GT(0, size);
+ EXPECT_FALSE(file_util::GetFileSize(path, &size));
// We should not be able to read the file.
int fd = base::OpenContentUriForRead(path);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698