Issue 93963003: Fix a test failure as GetFileSize() will not set the size if it fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93963003: Fix a test failure as GetFileSize() will not set the size if it fails (Closed)

Created:
7 years ago by qinmin

Modified:
7 years ago

Reviewers:
Nico, eugenis

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix a test failure as GetFileSize() will not set the size if it fails When GetFileSize() fails, it does not set the size. The test should test the return value rather than the size. BUG=324841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238180

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/file_util_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/93963003/1

7 years ago (2013-12-02 18:36:24 UTC) #3

Message was sent while issue was closed.

Change committed as 238180