Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939623002: Add TypeChecking=Unrestricted to Web Animation APIs (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
dstockwell, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Jens Widell, Mike Lawther (Google), rjwright, shans, Steve Block, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to Web Animation APIs This CL enables type-checking of IDL floating point values on interfaces: AnimationPlayer, AnimationTimeline and Timing and the dictionaries: AnimationPlayerEventInit, ComputedTimingProperties and WebKitAnimationEventInit Per AnimationTiming{,ReadOnly} in the current draft specification, make Timing.duration and Timing.iterations 'unrestricted double', while keeping other attributes as "restricted". BUG=335350, 354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190474

Patch Set 1 #

Patch Set 2 : Dictionaries too. #

Patch Set 3 : Adjust AnimationEvent constructor tests. #

Total comments: 2

Patch Set 4 : Remove isfinite checks in AnimationPlayer. #

Patch Set 5 : Drop AnimationAnimationPlayerTest.SetCurrentTimeUnrestrictedDouble #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -68 lines) Patch
M LayoutTests/fast/events/constructors/animation-event-constructor.html View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/constructors/animation-event-constructor-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/constructors/webkit-animation-event-constructor.html View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/constructors/webkit-animation-event-constructor-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/web-animations-api/player.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationNodeTiming.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationNodeTiming.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/AnimationTimeline.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/ComputedTimingProperties.idl View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/animation/Timing.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/events/AnimationPlayerEventInit.idl View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/events/WebKitAnimationEventInit.idl View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
fs
5 years, 10 months ago (2015-02-18 11:17:51 UTC) #2
Timothy Loh
On 2015/02/18 11:17:51, fs wrote: lgtm
5 years, 10 months ago (2015-02-18 23:54:44 UTC) #3
dstockwell
https://codereview.chromium.org/939623002/diff/40001/Source/core/animation/AnimationPlayer.idl File Source/core/animation/AnimationPlayer.idl (right): https://codereview.chromium.org/939623002/diff/40001/Source/core/animation/AnimationPlayer.idl#newcode36 Source/core/animation/AnimationPlayer.idl:36: TypeChecking=Unrestricted, There are checks in cpp which can be ...
5 years, 10 months ago (2015-02-19 01:10:45 UTC) #4
fs
https://codereview.chromium.org/939623002/diff/40001/Source/core/animation/AnimationPlayer.idl File Source/core/animation/AnimationPlayer.idl (right): https://codereview.chromium.org/939623002/diff/40001/Source/core/animation/AnimationPlayer.idl#newcode36 Source/core/animation/AnimationPlayer.idl:36: TypeChecking=Unrestricted, On 2015/02/19 01:10:45, dstockwell wrote: > There are ...
5 years, 10 months ago (2015-02-19 10:24:33 UTC) #6
dstockwell
lgtm
5 years, 10 months ago (2015-02-19 12:07:56 UTC) #7
fs
Apparently there was also a unit-test for the C++-side of AnimationPlayer.currentTime (AnimationAnimationPlayerTest.SetCurrentTimeUnrestrictedDouble). Didn't seem useful ...
5 years, 10 months ago (2015-02-19 12:25:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939623002/80001
5 years, 10 months ago (2015-02-19 14:25:22 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:42:19 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190474

Powered by Google App Engine
This is Rietveld 408576698