Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939613002: Add [TypeChecking=Unrestricted] on DevToolsHost interface (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, arv+blink, vivekg_samsung, malch+blink_chromium.org, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] on DevToolsHost interface The only definition that this actually affects is a method with a custom implementation, so the IDL change is just for show. Also adjust the custom implementation of this method to be closer to normal generated code in handling its float arguments, thereby actually making them restricted and thus honoring the [TypeChecking=Unrestricted] flag. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/inspector/DevToolsHost.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 10 months ago (2015-02-18 07:54:14 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-18 08:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939613002/1
5 years, 10 months ago (2015-02-18 08:21:24 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 09:36:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190405

Powered by Google App Engine
This is Rietveld 408576698