Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html - Issue 939603002: Adding support for Smart GO NEXT feature in Android Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html

Issue 939603002: Adding support for Smart GO NEXT feature in Android Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed build breaks in disabled element form. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/web/tests/WebViewTest.cpp ('K') | « Source/web/tests/WebViewTest.cpp ('k') | Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html » ('j') | Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <h3>form4 starts here</h3><br>
	kochi 2015/08/06 02:21:00 nit: as the big HTML file is split and this file o nit: as the big HTML file is split and this file only contains one form, you don't need this marker. AKV 2015/08/06 08:39:33 Done. Show quoted text On 2015/08/06 02:21:00, Takayoshi Kochi wrote: > nit: as the big HTML file is split and this file only contains one form, you > don't need this marker. Done.
	4 <form id="form4">
	kochi 2015/08/06 02:21:00 nit: as this file contains only one form, any id i nit: as this file contains only one form, any id is unique for this form - renumbering these ids is not essential, but it makes these tests look better. In the future, someone may wonder why the number starts from 0 or 1, and he/she has to research the review history of this file to learn why the number starts from 4. AKV 2015/08/06 08:39:33 Done. Show quoted text On 2015/08/06 02:21:00, Takayoshi Kochi wrote: > nit: as this file contains only one form, any id is unique for this form - > renumbering these ids is not essential, but it makes these tests look better. > In the future, someone may wonder why the number starts from 0 or 1, and he/she > has to research the review history of this file to learn why the number starts > from 4. Done.
	5 <div id="contenteditable6" contenteditable="true">contenteditable6 from form4< /div><br>

	6 <input type="text" id="input7" disabled value="input7 from form4 but skipped d ue to disabled element"><br>

	7 <input type="text" id="input8" readonly value="input8 from form4 but skipped d ue to readonly element"><br>

	8 <textarea id="textarea7" disabled readonly>textarea7 from form4 but skipped du e to disabled and readonly element</textarea><br>

	9 <div id="contenteditable7" contenteditable="true">contenteditable7 from form4< /div><br>

	10 </form>

	11 <h3>form4 ends here</h3><br>
	kochi 2015/08/06 02:21:00 nit: ditto as line 3. nit: ditto as line 3. AKV 2015/08/06 08:39:33 Done. Show quoted text On 2015/08/06 02:21:00, Takayoshi Kochi wrote: > nit: ditto as line 3. Done.
	12 </body>

	13 </html>

OLD	NEW