Chromium Code Reviews Chromium Code Reviews
Issue 939603002:
Adding support for Smart GO NEXT feature in Android Chrome (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <html> | |
| 2 <body> | |
| 3 <h3>form1 starts here</h3> | |
| 4 <form id="form1"> | |
| 5 <input type="text" id="input1" form="form1" value="input1 from form1"><br> | |
| 6 <button type="button" id="button1" form="form1">button1 from form1</button><br > | |
| 7 <div id="contenteditable1" contenteditable="true">contenteditable1 from form1< /div><br> | |
| 8 <!-- If any of this form element can handle key event, software keyboard shoul d show ENTER key instead of GO key, for textarea element it's exceptional, as it requires ENTER key by default for enabling multiline inputs. (This will be dete rmined from Chromium layer)" --> | |
|
kochi
2015/08/05 10:15:13
I'd prefer entering break the line at some point (
AKV
2015/08/05 13:42:50
Done.
| |
| 9 <div id="div1" onkeypress="alert('if key event is handled, software keyboard s hould show ENTER key instead of GO key');"><br> | |
| 10 <input type="text" id="input2" value="input2 from div1 form1"><br> | |
| 11 </div> | |
| 12 <a href="#" id="anchor1">anchor1 from form1</a><br> | |
| 13 <textarea id="textarea1">textarea1 from form1</textarea><br> | |
| 14 <input type="text" id="input3" value="input3 from form1"><br> | |
| 15 </form> | |
| 16 <h3>form1 ends here</h3> | |
| 17 <textarea id="textarea2" form="form1">textarea2 from form1, which is outside par ent hierarchy</textarea><br> | |
| 18 <textarea id="textarea3">textarea3 neither from form1 nor from form2</textarea>< br> | |
| 19 <button type="button" id="button2" form="form1">button2 from form1, which is out side parent hierarchy, but can't navigate due to non-editable element</button><b r> | |
| 20 <div id="contenteditable2" contenteditable="true">contenteditable2 neither from form1 nor from form2</div><br> | |
| 21 <textarea id="textarea4" form="formInvalid">textarea4 neither from form1 nor fro m form2, form attribute is invalid</textarea><br> | |
| 22 <h3>form2 starts here</h3><br> | |
| 23 <!-- If any of this form element can handle key event, software keyboard should show ENTER key instead of GO key, for textarea element it's exceptional, as it r equires ENTER key by default for enabling multiline inputs. (This will be determ ined from Chromium layer)" --> | |
|
kochi
2015/08/05 10:15:13
Ditto - it may look smarter if these comments are
AKV
2015/08/05 13:42:50
Done. Moved to top of the first form. Thanks
| |
| 24 <form id="form2" onkeypress="alert('if key event is handled, software keyboard s hould show ENTER key instead of GO key');"> | |
| 25 <textarea id="textarea5">textarea5 from form2</textarea><br> | |
| 26 <input type="text" id="input4" value="input4 from form2"><br> | |
| 27 <div id="contenteditable3" contenteditable="true">contenteditable3 from form2< /div><br> | |
| 28 <a href="#" id="anchor2">anchor2 from form2</a><br> | |
| 29 </form> | |
| 30 <h3>form2 ends here</h3><br> | |
| 31 <h3>form3 starts here</h3><br> | |
| 32 <form id="form3"> | |
| 33 <input type="text" id="input5" value="input5 from form3" tabindex="2"><br> | |
| 34 <div id="contenteditable4" contenteditable="true" tabindex="3">contenteditable 4 from form3</div><br> | |
| 35 <a href="#" id="anchor3" tabindex="4">anchor3 from form3</a><br> | |
| 36 <textarea id="textarea6" tabindex="1">textarea6 from form3</textarea><br> | |
| 37 <div id="contenteditable5" contenteditable="true" tabindex="-1">contenteditabl e5 from form3, but not considered for navigation due to invalid tabindex</div><b r> | |
| 38 <input type="text" id="input6" value="input6 from form3" tabindex="5"><br> | |
| 39 </form> | |
| 40 <h3>form3 ends here</h3><br> | |
| 41 <h3>form4 starts here</h3><br> | |
| 42 <form id="form4"> | |
| 43 <div id="contenteditable6" contenteditable="true">contenteditable6 from form4< /div><br> | |
| 44 <input type="text" id="input7" disabled value="input7 from form4 but skipped d ue to disabled element"><br> | |
| 45 <input type="text" id="input8" readonly value="input8 from form4 but skipped d ue to readonly element"><br> | |
| 46 <textarea id="textarea7" disabled readonly>textarea7 from form4 but skipped du e to disabled and readonly element</textarea><br> | |
| 47 <div id="contenteditable7" contenteditable="true">contenteditable7 from form4< /div><br> | |
| 48 </form> | |
| 49 <h3>form4 ends here</h3><br> | |
| 50 </body> | |
| 51 </html> | |
| OLD | NEW |
