ui/webui/resources/cr_elements/cr_button/demo.html - Issue 939533002: Add a cr-button element, a thin wrapper around paper-button.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_button/demo.html

Issue 939533002: Add a cr-button element, a thin wrapper around paper-button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary role. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_settings/md_settings.css ('K') | « ui/webui/resources/cr_elements/cr_button/cr_button.js ('k') | ui/webui/resources/cr_elements_resources.grdp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	michaelpg 2015/02/21 01:23:05 nit: lowercase for consistency nit: lowercase for consistency Jeremy Klein 2015/02/21 01:52:22 Done. Show quoted text On 2015/02/21 01:23:05, michaelpg wrote: > nit: lowercase for consistency Done. James Hawkins 2015/02/23 20:08:51 For future reference, the Google HTML style guide Show quoted text On 2015/02/21 01:52:22, Jeremy Klein wrote: > On 2015/02/21 01:23:05, michaelpg wrote: > > nit: lowercase for consistency > > Done. For future reference, the Google HTML style guide requires all lowercase (for HTML element names, attributes, attribute values (unless text/CDATA), CSS selectors, properties, and property values (except strings)).
	2 <html>

	3 <head>

	4 <link href="cr_button.html" rel="import">

	5 <link href="chrome://resources/polymer/core-icon/core-icon.html" rel="import">

	6 <link href="chrome://resources/polymer/core-icons/core-icons.html" rel="import ">

	7 </head>

	8 <body unresolved>

	9 <cr-button>Flat button</cr-button>

	10 <cr-button raised>Raised Button</cr-button>

	11 <cr-button disabled>Disabled Button</cr-button>

	12 <cr-button><core-icon icon="mail"></core-icon> Custom button</cr-button>
	michaelpg 2015/02/21 01:23:04 ouch, does it really require the   encoded li ouch, does it really require the   encoded like that? Jeremy Klein 2015/02/21 01:52:22 Well it isn't the only way to get the spacing (I c Show quoted text On 2015/02/21 01:23:04, michaelpg wrote: > ouch, does it really require the   encoded like that? Well it isn't the only way to get the spacing (I could add a margin-right to the icon), but a normal space will be stripped and I felt like this was ok for a demo. If you'd rather I do the margin, that's fine with me too. michaelpg 2015/02/25 00:35:00 i see. maybe we should consider defining the margi Show quoted text On 2015/02/21 01:52:22, Jeremy Klein wrote: > On 2015/02/21 01:23:04, michaelpg wrote: > > ouch, does it really require the   encoded like that? > > Well it isn't the only way to get the spacing (I could add a margin-right to the > icon), but a normal space will be stripped and I felt like this was ok for a > demo. If you'd rather I do the margin, that's fine with me too. i see. maybe we should consider defining the margin in cr_button.css? but we should wait and see how we use it in real life.
	13 </body>

	14 </html>

OLD	NEW