ui/webui/resources/cr_elements/cr_button/cr_button.html - Issue 939533002: Add a cr-button element, a thin wrapper around paper-button.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_button/cr_button.html

Issue 939533002: Add a cr-button element, a thin wrapper around paper-button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_settings/md_settings.html ('K') | « ui/webui/resources/cr_elements/cr_button/cr_button.css ('k') | ui/webui/resources/cr_elements/cr_button/cr_button.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.ht ml">

	3

	4 <polymer-element name="cr-button" role="button">
	michaelpg 2015/02/19 00:20:17 since the <paper-button> already has role=button, since the <paper-button> already has role=button, I believe this is redundant and may cause issues. I could be wrong, it's hard to tell empirically because support for shadow DOM isn't great yet anyway. Jeremy Klein 2015/02/20 23:20:33 Yeah you might be right. I wasn't 100% sure on thi Show quoted text On 2015/02/19 00:20:17, michaelpg wrote: > since the <paper-button> already has role=button, I believe this is redundant > and may cause issues. I could be wrong, it's hard to tell empirically because > support for shadow DOM isn't great yet anyway. Yeah you might be right. I wasn't 100% sure on this. Pinging dmazzoni again on this one. Jeremy Klein 2015/02/21 00:18:12 Verified off-thread with Dominic that you're right Show quoted text On 2015/02/20 23:20:33, Jeremy Klein wrote: > On 2015/02/19 00:20:17, michaelpg wrote: > > since the <paper-button> already has role=button, I believe this is redundant > > and may cause issues. I could be wrong, it's hard to tell empirically because > > support for shadow DOM isn't great yet anyway. > > Yeah you might be right. I wasn't 100% sure on this. Pinging dmazzoni again on > this one. Verified off-thread with Dominic that you're right here. Removed the role.
	5 <template>

	6 <link rel="stylesheet" href="cr_button.css">

	7

	8 <paper-button disabled?="{{disabled}}" raised?="{{raised}}">

	9 <content></content>

	10 </paper-button>

	11 </template>

	12 <script src="cr_button.js"></script>

	13 </polymer-element>

OLD	NEW