Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 939523004: Copied files from depot_tools. (Closed)

Created:
5 years, 10 months ago by pgervais
Modified:
5 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed review comments #

Patch Set 3 : Removed one more file. #

Patch Set 4 : Added some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1690 lines, -1 line) Patch
M testing_support/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M testing_support/auto_stub.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A testing_support/fake_repos.py View 1 chunk +972 lines, -0 lines 0 comments Download
A testing_support/filesystem_mock.py View 1 chunk +89 lines, -0 lines 0 comments Download
A testing_support/patches_data.py View 1 chunk +351 lines, -0 lines 0 comments Download
A testing_support/tests/__init__.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A testing_support/tests/auto_stub_test.py View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A testing_support/tests/trial_dir_test.py View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
A testing_support/trial_dir.py View 1 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
pgervais
I copied several files from depot_tools/testing_support to the standalone testing_support, and made sure that auto_stub.py ...
5 years, 10 months ago (2015-02-18 23:04:32 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/939523004/diff/1/testing_support/coverage_utils.py File testing_support/coverage_utils.py (right): https://chromiumcodereview.appspot.com/939523004/diff/1/testing_support/coverage_utils.py#newcode3 testing_support/coverage_utils.py:3: # found in the LICENSE file. Let's move this ...
5 years, 10 months ago (2015-02-19 00:22:39 UTC) #3
pgervais
Addressed your comments, ptal. https://chromiumcodereview.appspot.com/939523004/diff/1/testing_support/coverage_utils.py File testing_support/coverage_utils.py (right): https://chromiumcodereview.appspot.com/939523004/diff/1/testing_support/coverage_utils.py#newcode3 testing_support/coverage_utils.py:3: # found in the LICENSE ...
5 years, 10 months ago (2015-02-19 00:45:57 UTC) #4
pgervais
new patchset uploaded, with some tests! ptal
5 years, 10 months ago (2015-02-19 18:53:31 UTC) #5
pgervais
On 2015/02/19 18:53:31, pgervais wrote: > new patchset uploaded, with some tests! > > ptal ...
5 years, 10 months ago (2015-02-20 22:04:04 UTC) #6
iannucci
lgtm
5 years, 10 months ago (2015-02-20 22:49:31 UTC) #7
pgervais
5 years, 10 months ago (2015-02-20 23:18:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
134e350cb5c6bfc14e8b8d0f0f0508ffc769d3bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698