Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: net/proxy/proxy_resolver_v8_tracing.h

Issue 939503004: Add LoadState reporting to the mojo proxy resolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy-resolver-mojo
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_mojo_unittest.cc ('k') | net/proxy/proxy_resolver_v8_tracing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_v8_tracing.h
diff --git a/net/proxy/proxy_resolver_v8_tracing.h b/net/proxy/proxy_resolver_v8_tracing.h
index 85aca519e7e2aa68df30ccc06f9613a4a61cc677..d1666638fb08b0387cae2bbf4c6f1a33337e587f 100644
--- a/net/proxy/proxy_resolver_v8_tracing.h
+++ b/net/proxy/proxy_resolver_v8_tracing.h
@@ -42,6 +42,19 @@ class NET_EXPORT_PRIVATE ProxyResolverV8Tracing
ProxyResolverErrorObserver* error_observer,
NetLog* net_log);
+ // Constructs a ProxyResolver that will issue DNS requests through
+ // |host_resolver|, forward Javascript errors through |error_observer|, and
+ // log Javascript errors and alerts to |net_log|. When the LoadState for a
+ // request changes, |on_load_state_changed| will be invoked with the
+ // RequestHandle for that request with the new LoadState.
+ //
+ // Note that the constructor takes ownership of |error_observer|, whereas
+ // |host_resolver| and |net_log| are expected to outlive |this|.
+ ProxyResolverV8Tracing(HostResolver* host_resolver,
+ ProxyResolverErrorObserver* error_observer,
+ NetLog* net_log,
+ const LoadStateChangedCallback& on_load_state_changed);
+
~ProxyResolverV8Tracing() override;
// ProxyResolver implementation:
@@ -75,6 +88,9 @@ class NET_EXPORT_PRIVATE ProxyResolverV8Tracing
// The number of outstanding (non-cancelled) jobs.
int num_outstanding_callbacks_;
+ // Invoked when the load state for a request changes.
+ const LoadStateChangedCallback on_load_state_changed_;
+
DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8Tracing);
};
« no previous file with comments | « net/proxy/proxy_resolver_mojo_unittest.cc ('k') | net/proxy/proxy_resolver_v8_tracing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698