Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: net/proxy/mojo_proxy_resolver_factory_impl.cc

Issue 939503004: Add LoadState reporting to the mojo proxy resolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy-resolver-mojo
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/proxy/mojo_proxy_resolver_factory_impl.h" 5 #include "net/proxy/mojo_proxy_resolver_factory_impl.h"
6 6
7 #include "net/dns/host_resolver_mojo.h" 7 #include "net/dns/host_resolver_mojo.h"
8 #include "net/proxy/mojo_proxy_resolver_impl.h" 8 #include "net/proxy/mojo_proxy_resolver_impl.h"
9 #include "net/proxy/proxy_resolver_v8.h" 9 #include "net/proxy/proxy_resolver_v8.h"
10 #include "net/proxy/proxy_resolver_v8_tracing.h" 10 #include "net/proxy/proxy_resolver_v8_tracing.h"
11 #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" 11 #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h"
12 12
13 namespace net { 13 namespace net {
14 namespace { 14 namespace {
15 15
16 scoped_ptr<ProxyResolver> CreateDefaultProxyResolver( 16 scoped_ptr<ProxyResolver> CreateDefaultProxyResolver(
17 HostResolver* host_resolver) { 17 HostResolver* host_resolver,
18 const LoadStateChangedCallback<ProxyResolver::RequestHandle>& callback) {
18 ProxyResolverV8::EnsureIsolateCreated(); 19 ProxyResolverV8::EnsureIsolateCreated();
19 return make_scoped_ptr( 20 return make_scoped_ptr(
20 new ProxyResolverV8Tracing(host_resolver, nullptr, nullptr)); 21 new ProxyResolverV8Tracing(host_resolver, nullptr, nullptr, callback));
21 } 22 }
22 23
23 // A class to manage the lifetime of a MojoProxyResolverImpl and a 24 // A class to manage the lifetime of a MojoProxyResolverImpl and a
24 // HostResolverMojo. An instance will remain while the message pipes for both 25 // HostResolverMojo. An instance will remain while the message pipes for both
25 // mojo connections remain open. 26 // mojo connections remain open.
26 class MojoProxyResolverHolder : public mojo::ErrorHandler { 27 class MojoProxyResolverHolder : public mojo::ErrorHandler {
27 public: 28 public:
28 MojoProxyResolverHolder( 29 MojoProxyResolverHolder(
29 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory, 30 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory,
30 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 31 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
31 interfaces::HostResolverPtr host_resolver); 32 interfaces::HostResolverPtr host_resolver);
32 33
33 private: 34 private:
34 // mojo::ErrorHandler override. 35 // mojo::ErrorHandler override.
35 void OnConnectionError() override; 36 void OnConnectionError() override;
36 37
38 void LoadStateChanged(ProxyResolver::RequestHandle handle,
39 LoadState load_state);
40
37 HostResolverMojo host_resolver_; 41 HostResolverMojo host_resolver_;
38 MojoProxyResolverImpl proxy_resolver_; 42 MojoProxyResolverImpl proxy_resolver_;
39 mojo::Binding<interfaces::ProxyResolver> binding_; 43 mojo::Binding<interfaces::ProxyResolver> binding_;
40 44
41 DISALLOW_COPY_AND_ASSIGN(MojoProxyResolverHolder); 45 DISALLOW_COPY_AND_ASSIGN(MojoProxyResolverHolder);
42 }; 46 };
43 47
44 MojoProxyResolverHolder::MojoProxyResolverHolder( 48 MojoProxyResolverHolder::MojoProxyResolverHolder(
45 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory, 49 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory,
46 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 50 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
47 interfaces::HostResolverPtr host_resolver) 51 interfaces::HostResolverPtr host_resolver)
48 : host_resolver_(host_resolver.Pass(), 52 : host_resolver_(host_resolver.Pass(),
49 base::Bind(&MojoProxyResolverHolder::OnConnectionError, 53 base::Bind(&MojoProxyResolverHolder::OnConnectionError,
50 base::Unretained(this))), 54 base::Unretained(this))),
51 proxy_resolver_(proxy_resolver_factory.Run(&host_resolver_)), 55 proxy_resolver_(proxy_resolver_factory.Run(
56 &host_resolver_,
57 base::Bind(&MojoProxyResolverHolder::LoadStateChanged,
58 base::Unretained(this)))),
52 binding_(&proxy_resolver_, request.Pass()) { 59 binding_(&proxy_resolver_, request.Pass()) {
53 binding_.set_error_handler(this); 60 binding_.set_error_handler(this);
54 } 61 }
55 62
56 void MojoProxyResolverHolder::OnConnectionError() { 63 void MojoProxyResolverHolder::OnConnectionError() {
57 delete this; 64 delete this;
58 } 65 }
59 66
67 void MojoProxyResolverHolder::LoadStateChanged(
68 ProxyResolver::RequestHandle handle,
69 LoadState load_state) {
70 proxy_resolver_.LoadStateChanged(handle, load_state);
71 }
72
60 } // namespace 73 } // namespace
61 74
62 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl( 75 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl(
63 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory, 76 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory,
64 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request) 77 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request)
65 : proxy_resolver_impl_factory_(proxy_resolver_factory), 78 : proxy_resolver_impl_factory_(proxy_resolver_factory),
66 binding_(this, request.Pass()) { 79 binding_(this, request.Pass()) {
67 } 80 }
68 81
69 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl( 82 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl(
70 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request) 83 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request)
71 : MojoProxyResolverFactoryImpl(base::Bind(&CreateDefaultProxyResolver), 84 : MojoProxyResolverFactoryImpl(base::Bind(&CreateDefaultProxyResolver),
72 request.Pass()) { 85 request.Pass()) {
73 } 86 }
74 87
75 MojoProxyResolverFactoryImpl::~MojoProxyResolverFactoryImpl() = default; 88 MojoProxyResolverFactoryImpl::~MojoProxyResolverFactoryImpl() = default;
76 89
77 void MojoProxyResolverFactoryImpl::CreateResolver( 90 void MojoProxyResolverFactoryImpl::CreateResolver(
78 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 91 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
79 interfaces::HostResolverPtr host_resolver) { 92 interfaces::HostResolverPtr host_resolver) {
80 // The MojoProxyResolverHolder will delete itself when either |request| or 93 // The MojoProxyResolverHolder will delete itself when either |request| or
81 // |host_resolver| encounters a connection error, that is, when either the 94 // |host_resolver| encounters a connection error, that is, when either the
82 // ProxyResolver client or the HostResolver implementation is deleted. 95 // ProxyResolver client or the HostResolver implementation is deleted.
83 new MojoProxyResolverHolder(proxy_resolver_impl_factory_, request.Pass(), 96 new MojoProxyResolverHolder(proxy_resolver_impl_factory_, request.Pass(),
84 host_resolver.Pass()); 97 host_resolver.Pass());
85 } 98 }
86 99
87 } // namespace net 100 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698